Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound variable error in start_ovs Bash script #1190

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix unbound variable error in start_ovs Bash script #1190

merged 1 commit into from
Sep 2, 2020

Conversation

antoninbas
Copy link
Contributor

Fixes #1171

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #1190 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
- Coverage   56.35%   56.29%   -0.07%     
==========================================
  Files         105      105              
  Lines       11529    11529              
==========================================
- Hits         6497     6490       -7     
- Misses       4465     4470       +5     
- Partials      567      569       +2
Flag Coverage Δ
#integration-tests 47.52% <ø> (+0.03%) ⬆️
#unit-tests 41.63% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/certificate/certificate.go 72.83% <0.00%> (-6.18%) ⬇️
pkg/apiserver/storage/ram/watch.go 85.71% <0.00%> (-3.18%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 73.43% <0.00%> (-0.56%) ⬇️
pkg/ovs/openflow/ofctrl_bridge.go 72.90% <0.00%> (+0.66%) ⬆️
pkg/apiserver/storage/ram/store.go 81.69% <0.00%> (+1.30%) ⬆️

tnqn
tnqn previously approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all

2 similar comments
@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-e2e
/test-networkpolicy
/test-conformance

jianjuns
jianjuns reviewed Sep 1, 2020
View reviewed changes
build/images/scripts/start_ovs Outdated
@@ -21,6 +21,8 @@ function cleanup_ovs_run_files {
rm -rf ${OVS_RUN_DIR}/.conf.db.*~lock~
}

# start_ovs takes one parameter: a boolean value which indicates whether OVS
# Kernel HW offload should be enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel -> kernel?

@antoninbas antoninbas force-pushed the fix-unbound-variable-in-start_ovs-script branch from 64a26a5 to 67ab3ee Compare September 2, 2020 00:03
jianjuns
jianjuns previously approved these changes Sep 2, 2020
View reviewed changes
tnqn
tnqn previously approved these changes Sep 2, 2020
View reviewed changes
@antoninbas antoninbas dismissed stale reviews from tnqn and jianjuns via 6b3f6e3 September 2, 2020 17:16
@antoninbas antoninbas force-pushed the fix-unbound-variable-in-start_ovs-script branch from 67ab3ee to 6b3f6e3 Compare September 2, 2020 17:16
@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-hw-offload

@antoninbas
Copy link
Contributor Author

/test-windows-conformance

@antoninbas
Copy link
Contributor Author

/test-networkpolicy

@antoninbas antoninbas merged commit 68245fc into antrea-io:master Sep 2, 2020
@antoninbas antoninbas deleted the fix-unbound-variable-in-start_ovs-script branch September 2, 2020 23:10
antoninbas added a commit to antoninbas/antrea that referenced this pull request Sep 3, 2020
@antoninbas
Fix unbound variable error in start_ovs Bash script (antrea-io#1190)
ec915f9 
Fixes antrea-io#1171
antoninbas added a commit to antoninbas/antrea that referenced this pull request Sep 3, 2020
@antoninbas
Fix unbound variable error in start_ovs Bash script (antrea-io#1190)
011ca1f 
Fixes antrea-io#1171
antoninbas added a commit to antoninbas/antrea that referenced this pull request Sep 3, 2020
@antoninbas
Fix unbound variable error in start_ovs Bash script (antrea-io#1190)
78460df 
Fixes antrea-io#1171
antoninbas added a commit to antoninbas/antrea that referenced this pull request Sep 3, 2020
@antoninbas
Fix unbound variable error in start_ovs Bash script (antrea-io#1190)
22ff4b9 
Fixes antrea-io#1171
antoninbas added a commit that referenced this pull request Sep 3, 2020
@antoninbas
Fix unbound variable error in start_ovs Bash script (#1190)
9c727fe 
Fixes #1171
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@antoninbas @GraysonWu
Fix unbound variable error in start_ovs Bash script (antrea-io#1190)
9477ab2 
Fixes antrea-io#1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@tnqn tnqn tnqn left review comments

@moshe010 moshe010 Awaiting requested review from moshe010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

antrea-ovs container crashed 5 times in about 6 minutes
6 participants
@antoninbas @antrea-bot @codecov-commenter @tnqn @jianjuns @vmwclabot