Add legacy networking API group for backward compatibility #1243

tnqn · 2020-09-14T09:16:26Z

Package networking is superseded by package controlplane in v0.9.3, to keep backward compatibility with up to two minor versions of antrea-agents, the API group should remain for two more minor releases.

This patch adds the APIs back and serves them with the same storage as controlplane API. Also, kind tests are added to make sure basic functionalities are not broken when only controller is upgraded.

Fixes #1250

antrea-bot · 2020-09-14T09:16:42Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-whole-conformance: to trigger all conformance tests on linux.
/skip-whole-conformance: to skip all conformance tests on linux.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-windows-conformance: to trigger windows conformance tests.
/skip-windows-conformance: to skip windows conformance tests.
/test-windows-networkpolicy: to trigger windows networkpolicy tests.
/skip-windows-networkpolicy: to skip windows networkpolicy tests.
/test-hw-offload: to trigger ovs hardware offload test.
/skip-hw-offload: to skip ovs hardware offload test.
/test-all: to trigger all tests (except whole conformance).
/skip-all: to skip all tests (except whole conformance).

codecov-commenter · 2020-09-14T09:20:50Z

Codecov Report

Merging #1243 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   56.26%   56.28%   +0.01%     
==========================================
  Files         109      109              
  Lines       12037    12045       +8     
==========================================
+ Hits         6773     6779       +6     
  Misses       4674     4674              
- Partials      590      592       +2

Flag	Coverage Δ
#integration-tests	`46.05% <ø> (+0.03%)`	⬆️
#unit-tests	`42.55% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/apis/controlplane/v1beta1/conversion.go	`42.85% <ø> (ø)`
pkg/apiserver/certificate/cacert_controller.go	`17.58% <ø> (ø)`
pkg/agent/proxy/types/types.go

tnqn · 2020-09-14T10:49:18Z

/test-all

tnqn · 2020-09-14T13:01:14Z

/test-windows-networkpolicy

tnqn · 2020-09-14T14:45:40Z

@jianjuns @antoninbas In addition to the basic compatibility test added in this PR, I have manually verified that 0.7.0 and 0.8.0 agent + this PR's controller can pass networkpolicy and conformance tests.

I think ideally we should support backward compatibility for all clients including antctl but not sure if we want to make an exception for this particular renaming, do you want me to add the APIService back to support antctl of previous versions? We may document the compatibility of Antrea components whatever the decision is.

antoninbas

Overall changes LGTM. I assume that everything in the diff that's not related to testing is just you adding back code that was previously deleted?

I am in favor of adding back the APIService to provide backwards-compatibility for antctl as well, unless you see an issue with it.

Even though I'll include information in the release notes, we need to start a document with a list of our APIs and the deprecation status when applicable. It can be pretty basic for now and we can improve it over time. It doesn't have to be as part of this PR either.

.github/workflows/kind_upgrade.yml

hack/generate-manifest.sh

pkg/apiserver/apiserver.go

ci/kind/test-upgrade-antrea.sh

tnqn

@antoninbas thanks for the input. I added the APIService back, will document the APIs in a separate PR.

.github/workflows/kind_upgrade.yml

ci/kind/test-upgrade-antrea.sh

hack/generate-manifest.sh

pkg/apiserver/apiserver.go

tnqn · 2020-09-15T02:50:52Z

I assume that everything in the diff that's not related to testing is just you adding back code that was previously deleted?

There is a little difference in "pkg/apis/networking" and "apiserver.go" compared with previously deleted code. It's reusing the controlplane storages and structs instead of its owns.

tnqn · 2020-09-15T03:20:16Z

/test-all

tnqn · 2020-09-15T03:56:02Z

/test-e2e

tnqn · 2020-09-15T04:57:33Z

/test-conformance

antoninbas

couple nits, otherwise LGTM

hack/generate-manifest.sh

tnqn · 2020-09-16T02:30:39Z

/test-all

antoninbas

LGTM

tnqn · 2020-09-17T01:55:03Z

@jianjuns will you review this? if not I'd like to merge this soon as it's needed for upgrade tests of other api-change PRs.

tnqn · 2020-09-17T01:55:16Z

/test-windows-networkpolicy

tnqn · 2020-09-17T03:12:26Z

/test-windows-networkpolicy

jianjuns

LGTM. Just a NIT.

pkg/apis/networking/v1beta1/conversion.go

Package networking is superseded by package controlplane in v0.9.3, to keep backward compatibility with up to two minor versions of antrea-agents, the API group should remain for two more minor releases. This patch adds the APIs back and serves them with the same storage as controlplane API. Also, kind tests are added to make sure basic functionalities are not broken when only controller is upgraded.

tnqn · 2020-09-17T03:21:45Z

/test-all

antoninbas

Approving again after typo fix

tnqn · 2020-09-17T05:18:30Z

/test-windows-networkpolicy

…#1243) Package networking is superseded by package controlplane in v0.9.3, to keep backward compatibility with up to two minor versions of antrea-agents, the API group should remain for two more minor releases. This patch adds the APIs back and serves them with the same storage as controlplane API. Also, kind tests are added to make sure basic functionalities are not broken when only controller is upgraded.

vmwclabot added the cla-not-required label Sep 14, 2020

tnqn force-pushed the api-compat branch 2 times, most recently from 58802ea to 7e94f96 Compare September 14, 2020 10:28

antoninbas reviewed Sep 14, 2020

View reviewed changes

tnqn commented Sep 15, 2020

View reviewed changes

tnqn force-pushed the api-compat branch from 7e94f96 to 2ad55d2 Compare September 15, 2020 02:48

tnqn added this to the Antrea v0.10.0 release milestone Sep 15, 2020

tnqn added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. label Sep 15, 2020

antoninbas reviewed Sep 15, 2020

View reviewed changes

hack/generate-manifest.sh Outdated Show resolved Hide resolved

hack/generate-manifest.sh Outdated Show resolved Hide resolved

tnqn force-pushed the api-compat branch from 2ad55d2 to fea7f1b Compare September 16, 2020 02:19

antoninbas previously approved these changes Sep 16, 2020

View reviewed changes

jianjuns previously approved these changes Sep 17, 2020

View reviewed changes

pkg/apis/networking/v1beta1/conversion.go Outdated Show resolved Hide resolved

tnqn dismissed stale reviews from jianjuns and antoninbas via 3d46d2b September 17, 2020 03:20

tnqn force-pushed the api-compat branch from fea7f1b to 3d46d2b Compare September 17, 2020 03:20

antoninbas approved these changes Sep 17, 2020

View reviewed changes

jianjuns approved these changes Sep 17, 2020

View reviewed changes

tnqn merged commit fd47097 into antrea-io:master Sep 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add legacy networking API group for backward compatibility #1243

Add legacy networking API group for backward compatibility #1243

tnqn commented Sep 14, 2020 •

edited

Loading

antrea-bot commented Sep 14, 2020

codecov-commenter commented Sep 14, 2020 •

edited

Loading

tnqn commented Sep 14, 2020

tnqn commented Sep 14, 2020

tnqn commented Sep 14, 2020

antoninbas left a comment

tnqn left a comment

tnqn commented Sep 15, 2020

tnqn commented Sep 15, 2020

tnqn commented Sep 15, 2020

tnqn commented Sep 15, 2020

antoninbas left a comment

tnqn commented Sep 16, 2020

antoninbas left a comment

tnqn commented Sep 17, 2020

tnqn commented Sep 17, 2020

tnqn commented Sep 17, 2020

jianjuns left a comment

tnqn commented Sep 17, 2020

antoninbas left a comment

tnqn commented Sep 17, 2020

Add legacy networking API group for backward compatibility #1243

Add legacy networking API group for backward compatibility #1243

Conversation

tnqn commented Sep 14, 2020 • edited Loading

antrea-bot commented Sep 14, 2020

codecov-commenter commented Sep 14, 2020 • edited Loading

Codecov Report

tnqn commented Sep 14, 2020

tnqn commented Sep 14, 2020

tnqn commented Sep 14, 2020

antoninbas left a comment

Choose a reason for hiding this comment

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented Sep 15, 2020

tnqn commented Sep 15, 2020

tnqn commented Sep 15, 2020

tnqn commented Sep 15, 2020

antoninbas left a comment

Choose a reason for hiding this comment

tnqn commented Sep 16, 2020

antoninbas left a comment

Choose a reason for hiding this comment

tnqn commented Sep 17, 2020

tnqn commented Sep 17, 2020

tnqn commented Sep 17, 2020

jianjuns left a comment

Choose a reason for hiding this comment

tnqn commented Sep 17, 2020

antoninbas left a comment

Choose a reason for hiding this comment

tnqn commented Sep 17, 2020

tnqn commented Sep 14, 2020 •

edited

Loading

codecov-commenter commented Sep 14, 2020 •

edited

Loading