Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start document with security recommendations #1296

Merged

Conversation

antoninbas
Copy link
Contributor

At the moment, the document discusses how to restrict access from Pods
to the OVSDB file persisted on each Node's filesystem.

At the moment, the document discusses how to restrict access from Pods
to the OVSDB file persisted on each Node's filesystem.
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@antoninbas antoninbas added the kind/documentation Categorizes issue or PR as related to a documentation. label Sep 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #1296 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   54.40%   54.39%   -0.02%     
==========================================
  Files         115      115              
  Lines       10807    10807              
==========================================
- Hits         5880     5878       -2     
- Misses       4353     4354       +1     
- Partials      574      575       +1     
Flag Coverage Δ
#integration-tests 44.95% <ø> (ø)
#unit-tests 41.46% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/storage/ram/store.go 77.44% <0.00%> (-1.51%) ⬇️

@abhiraut
Copy link
Contributor

wonder what the scope of this document will be going further? best practices? or only security related? if former then shall we name it best-practices.md?

@antoninbas
Copy link
Contributor Author

antoninbas commented Sep 25, 2020

@abhiraut probably just security related, that's how I envision it

A bit like https://kubernetes.io/docs/concepts/security/

@abhiraut
Copy link
Contributor

abhiraut commented Oct 1, 2020

@abhiraut probably just security related, that's how I envision it

A bit like https://kubernetes.io/docs/concepts/security/

nice.. i had not seen the 4Cs of security before.

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit f0548f1 into antrea-io:master Oct 6, 2020
@antoninbas antoninbas deleted the add-security-recommendations-doc branch October 6, 2020 17:42
antoninbas added a commit to antoninbas/antrea that referenced this pull request Nov 10, 2020
At the moment, the document discusses how to restrict access from Pods
to the OVSDB file persisted on each Node's filesystem.
antoninbas added a commit that referenced this pull request Nov 11, 2020
At the moment, the document discusses how to restrict access from Pods
to the OVSDB file persisted on each Node's filesystem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants