Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent definition of IPFIX field in Kibana #1370

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

zyiou
Copy link
Contributor

@zyiou zyiou commented Oct 13, 2020

Fixes #1368

Tested with new Kibana definition file and the dashboard can show destination services related graph:

Screen Shot 2020-10-13 at 3 39 50 PM

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #1370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1370   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files         159      159           
  Lines       12674    12674           
=======================================
  Hits         8158     8158           
+ Misses       3666     3659    -7     
- Partials      850      857    +7     
Flag Coverage Δ
#integration-tests 44.82% <ø> (ø)
#kind-e2e-tests 50.47% <ø> (+0.47%) ⬆️
#unit-tests 42.08% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ver/registry/controlplane/nodestatssummary/rest.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/apiserver/certificate/certificate.go 71.05% <0.00%> (-6.58%) ⬇️
pkg/agent/stats/collector.go 91.95% <0.00%> (-5.75%) ⬇️
...kg/controller/networkpolicy/store/networkpolicy.go 77.96% <0.00%> (-3.39%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 80.83% <0.00%> (+0.13%) ⬆️
...ntroller/networkpolicy/networkpolicy_controller.go 69.25% <0.00%> (+3.33%) ⬆️
pkg/apis/controlplane/v1beta1/sets.go 44.11% <0.00%> (+7.35%) ⬆️

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you know why the entire file has changed, instead of just the field name?

@zyiou
Copy link
Contributor Author

zyiou commented Oct 14, 2020

Thanks for reviewing. The file is auto-generated and exported from Kibana web page so I think little formatting difference will cause the whole file change (this happens every time I changes and re-generates this ndjson file). Also I fixed a small grouping function bug in one of the graphs, that may also cause the difference.

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas antoninbas merged commit 09dd09f into antrea-io:master Oct 16, 2020
antoninbas pushed a commit to antoninbas/antrea that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFix field name wrong in reference Kibana dashboard definition file
5 participants