Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated Prometheus metrics #1503

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

srikartati
Copy link
Member

antrea_agent_runtime_info and antrea_controller_runtime_info are
deprecated since 0.10.0 release. Deleting them from 0.11.0 release.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-all-features-conformance: to trigger conformance tests with all alpha features enabled.
  • /skip-all-features-conformance: to skip conformance tests with all alpha features enabled.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

antoninbas
antoninbas previously approved these changes Nov 6, 2020
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antrea_agent_runtime_info and antrea_controller_runtime_info are
deprecated since 0.10.0 release. Deleting them from 0.11.0 release.
@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #1503 (96febf9) into master (619b678) will decrease coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
- Coverage   68.54%   67.45%   -1.10%     
==========================================
  Files         165      169       +4     
  Lines       13142    13392     +250     
==========================================
+ Hits         9008     9033      +25     
- Misses       3197     3421     +224     
- Partials      937      938       +1     
Flag Coverage Δ
integration-tests 45.62% <ø> (+0.12%) ⬆️
kind-e2e-tests 54.48% <ø> (-0.41%) ⬇️
unit-tests 41.70% <ø> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/metrics/prometheus.go 42.42% <ø> (+11.98%) ⬆️
pkg/controller/metrics/prometheus.go 0.00% <ø> (ø)
pkg/features/antrea_features.go 16.66% <0.00%> (-83.34%) ⬇️
pkg/controller/networkpolicy/tier.go 90.00% <0.00%> (-10.00%) ⬇️
pkg/apis/controlplane/v1beta2/sets.go 38.88% <0.00%> (-5.56%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 82.82% <0.00%> (-0.15%) ⬇️
cmd/antrea-agent/agent.go 0.00% <0.00%> (ø)
cmd/antrea-agent/main.go 0.00% <0.00%> (ø)
cmd/antrea-agent/options_linux.go 0.00% <0.00%> (ø)
cmd/antrea-agent/options.go 21.49% <0.00%> (ø)
... and 2 more

@srikartati
Copy link
Member Author

/test-all

@srikartati
Copy link
Member Author

/test-e2e

@srikartati
Copy link
Member Author

/test-all-features

@srikartati
Copy link
Member Author

srikartati commented Nov 9, 2020

LGTM

@antoninbas Could you please review the patch again?

@antoninbas
Copy link
Contributor

Using admin privileges to merge because of changes in branch protection settings

@antoninbas antoninbas merged commit 14cc500 into antrea-io:master Nov 9, 2020
@srikartati srikartati deleted the delete_prom_metrics branch November 9, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants