[Windows] Provide workaround to install Hyper-V without CPU check #1744

ruicao93 · 2021-01-14T02:10:06Z

Provide workaround to install Hyper-V without CPU virtualization
capability check. In this way, users could deploy antrea on the
testbed without virtualization capability.

Signed-off-by: Rui Cao rcao@vmware.com

Provide workaround to install Hyper-V without CPU virtualization capability check. In this way, users could deploy antrea on the testbed without virtualization capability. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2021-01-14T02:13:16Z

/skip-all

docs/windows.md

Provide workaround to install Hyper-V without CPU virtualization capability check. In this way, users could deploy antrea on the nodes without virtualization capability. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2021-01-14T12:09:43Z

Thanks @tnqn . Address the comments.

ruicao93 · 2021-01-14T12:10:20Z

/skip-all

codecov-io · 2021-01-14T12:43:49Z

Codecov Report

Merging #1744 (94f9233) into master (9d3d10b) will decrease coverage by 1.94%.
The diff coverage is 65.26%.

@@            Coverage Diff             @@
##           master    #1744      +/-   ##
==========================================
- Coverage   63.31%   61.37%   -1.95%     
==========================================
  Files         170      192      +22     
  Lines       14250    16371    +2121     
==========================================
+ Hits         9023    10048    +1025     
- Misses       4292     5270     +978     
- Partials      935     1053     +118

Flag	Coverage Δ
kind-e2e-tests	`50.25% <56.15%> (-5.14%)`	⬇️
unit-tests	`42.63% <39.78%> (+1.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../agent/apiserver/handlers/networkpolicy/handler.go	`58.33% <ø> (ø)`
...gent/controller/noderoute/node_route_controller.go	`45.83% <0.00%> (-0.64%)`	⬇️
pkg/agent/proxy/proxier.go	`75.92% <ø> (+1.11%)`	⬆️
pkg/agent/proxy/proxier_linux.go	`33.33% <ø> (+8.33%)`	⬆️
pkg/agent/proxy/service.go	`100.00% <ø> (ø)`
pkg/agent/proxy/types/groupcounter.go	`95.23% <ø> (+0.23%)`	⬆️
pkg/agent/proxy/types/types.go	`46.66% <ø> (-37.95%)`	⬇️
pkg/agent/querier/querier.go	`88.46% <ø> (+0.30%)`	⬆️
pkg/agent/route/route_linux.go	`44.48% <ø> (+0.38%)`	⬆️
pkg/agent/stats/collector.go	`97.72% <ø> (ø)`
... and 153 more

docs/windows.md

antoninbas

so this PR is not directly related to #1733?

and this is purely a documentation PR, we don't need to update any script?

docs/windows.md

Provide workaround to install Hyper-V without CPU virtualization capability check. In this way, users could deploy antrea on the nodes without virtualization capability. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2021-01-15T01:49:06Z

so this PR is not directly related to #1733?

and this is purely a documentation PR, we don't need to update any script?

@antoninbas No, these two PRs are for different purposes.

#1733 is for the Windows Nodes which don't install the Hyper-V feature at all. And the change in script is for the following OVS which supports Hyper-V disablement:

Current NSX-OVS
The future OVS which supports Hyper-V disablement.

vicky-liu · 2021-01-15T02:53:02Z

@ruicao93 , NSXT OVS is not applied for upstream, so do you think it possible to move the installation change #1733 out of Antrea upstream? After upstream OVS really supports hyper-v disablement, then we can add the installation script back to upstream.

ruicao93 · 2021-01-15T04:03:27Z

@ruicao93 , NSXT OVS is not applied for upstream, so do you think it possible to move the installation change #1733 out of Antrea upstream? After upstream OVS really supports hyper-v disablement, then we can add the installation script back to upstream.

@vicky-liu , actually the PR #1733 is not specific for Hyper-V disablement. I just changed some installation operations to make them more generic. The result is it could also provide compatibility for Hyper-V disablement very well.

So it's ok to merge the PR. I may need to update the commit msg to avoid confusion. Curently I use the workds "Hyper-V disablement" because reviewers may hard to unstand the PR if I put two many details.

ruicao93 · 2021-01-16T01:14:00Z

/skip-all

jianjuns · 2021-01-16T04:05:06Z

docs/windows.md

@@ -328,3 +330,47 @@ the HNS Network created by antrea-agent is removed, and the Open vSwitch
 Extension is disabled by default. In this case, the stale OVS bridge and ports
 should be removed. A help script [Clean-AntreaNetwork.ps1](https://raw.githubusercontent.com/vmware-tanzu/antrea/master/hack/windows/Clean-AntreaNetwork.ps1)
 can be used to clean the OVS bridge.
+
+2. Hyper-V feature cannot be installed on Windows node due to the processor not


Windows node -> the Windows Node

jianjuns · 2021-01-16T04:05:43Z

docs/windows.md

+2. Hyper-V feature cannot be installed on Windows node due to the processor not
+having the required virtualization capabilities.
+
+    If the processor of the Windows node does not have the required


node -> Node

Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 · 2021-01-16T04:21:44Z

/skip-all

[Windows] Provide workaround to install Hyper-V without CPU check

9534d80

Provide workaround to install Hyper-V without CPU virtualization capability check. In this way, users could deploy antrea on the testbed without virtualization capability. Signed-off-by: Rui Cao <rcao@vmware.com>

vmwclabot added the cla-not-required label Jan 14, 2021

ruicao93 requested review from jianjuns and tnqn January 14, 2021 02:12

tnqn reviewed Jan 14, 2021

View reviewed changes

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

[Windows] Provide workaround to install Hyper-V without CPU check

5f4d87b

Provide workaround to install Hyper-V without CPU virtualization capability check. In this way, users could deploy antrea on the nodes without virtualization capability. Signed-off-by: Rui Cao <rcao@vmware.com>

ruicao93 force-pushed the hyperv_doc branch from 6513940 to 5f4d87b Compare January 14, 2021 12:07

jianjuns reviewed Jan 14, 2021

View reviewed changes

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

docs/windows.md Outdated Show resolved Hide resolved

antoninbas reviewed Jan 14, 2021

View reviewed changes

docs/windows.md Outdated Show resolved Hide resolved

[Windows] Provide workaround to install Hyper-V without CPU check

d7a4558

Provide workaround to install Hyper-V without CPU virtualization capability check. In this way, users could deploy antrea on the nodes without virtualization capability. Signed-off-by: Rui Cao <rcao@vmware.com>

jianjuns reviewed Jan 16, 2021

View reviewed changes

Address comments

94f9233

Signed-off-by: Rui Cao <rcao@vmware.com>

jianjuns approved these changes Jan 16, 2021

View reviewed changes

ruicao93 merged commit 30ba724 into antrea-io:master Jan 16, 2021

ruicao93 mentioned this pull request Feb 23, 2021

Run Windows antrea-agent without Hyper-V #1645

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Windows] Provide workaround to install Hyper-V without CPU check #1744

[Windows] Provide workaround to install Hyper-V without CPU check #1744

ruicao93 commented Jan 14, 2021

ruicao93 commented Jan 14, 2021

ruicao93 commented Jan 14, 2021 •

edited

Loading

ruicao93 commented Jan 14, 2021

codecov-io commented Jan 14, 2021 •

edited

Loading

antoninbas left a comment

ruicao93 commented Jan 15, 2021 •

edited

Loading

vicky-liu commented Jan 15, 2021

ruicao93 commented Jan 15, 2021 •

edited

Loading

ruicao93 commented Jan 16, 2021

jianjuns Jan 16, 2021

ruicao93 Jan 16, 2021

jianjuns Jan 16, 2021

ruicao93 Jan 16, 2021

ruicao93 commented Jan 16, 2021

[Windows] Provide workaround to install Hyper-V without CPU check #1744

[Windows] Provide workaround to install Hyper-V without CPU check #1744

Conversation

ruicao93 commented Jan 14, 2021

ruicao93 commented Jan 14, 2021

ruicao93 commented Jan 14, 2021 • edited Loading

ruicao93 commented Jan 14, 2021

codecov-io commented Jan 14, 2021 • edited Loading

Codecov Report

antoninbas left a comment

Choose a reason for hiding this comment

ruicao93 commented Jan 15, 2021 • edited Loading

vicky-liu commented Jan 15, 2021

ruicao93 commented Jan 15, 2021 • edited Loading

ruicao93 commented Jan 16, 2021

jianjuns Jan 16, 2021

Choose a reason for hiding this comment

ruicao93 Jan 16, 2021

Choose a reason for hiding this comment

jianjuns Jan 16, 2021

Choose a reason for hiding this comment

ruicao93 Jan 16, 2021

Choose a reason for hiding this comment

ruicao93 commented Jan 16, 2021

ruicao93 commented Jan 14, 2021 •

edited

Loading

codecov-io commented Jan 14, 2021 •

edited

Loading

ruicao93 commented Jan 15, 2021 •

edited

Loading

ruicao93 commented Jan 15, 2021 •

edited

Loading