-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct output format for CNI Add in networkPolicyOnly mode #2037
Use correct output format for CNI Add in networkPolicyOnly mode #2037
Conversation
As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes antrea-io#2002
Codecov Report
@@ Coverage Diff @@
## main #2037 +/- ##
===========================================
+ Coverage 41.69% 61.59% +19.90%
===========================================
Files 127 265 +138
Lines 15844 19770 +3926
===========================================
+ Hits 6606 12178 +5572
+ Misses 8684 6331 -2353
- Partials 554 1261 +707
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Quan. I will run the cloud tests and also validate the fix manually for containerd with AKS. |
/test-all |
I've verified this patch with our 3 cloud CI jobs (AKS / GKE / EKS)
With the patch:
NodeInfo:
|
…ea-io#2037) As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes antrea-io#2002
…ea-io#2037) As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes antrea-io#2002
As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes #2002
…ea-io#2037) As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes antrea-io#2002
As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes #2002
…ea-io#2037) As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes antrea-io#2002
As per the CNI specification for the Add command: > If the plugin was supplied a prevResult as part of its input configuration, it MUST handle prevResult by either passing it through, or modifying it appropriately. In networkPolicyOnly mode, CNI chaining is used. Antrea receives a prevResult from the container runtime and must output it in case of success. We do not make any changes to the result, but we may convert it to a different CNI version format (the default one for Antrea). Previously, Antrea would output the entire input configuration (which does include prevResult), which would cause containerd to return an error. The integration test was incorrect and had to be fixed. Fixes #2002
As per the CNI specification for the Add command:
In networkPolicyOnly mode, CNI chaining is used. Antrea receives a
prevResult from the container runtime and must output it in case of
success. We do not make any changes to the result, but we may convert it
to a different CNI version format (the default one for Antrea).
Previously, Antrea would output the entire input configuration (which
does include prevResult), which would cause containerd to return an
error.
The integration test was incorrect and had to be fixed.
Fixes #2002