Automated cherry pick of #2302: Fix MarshalJSON error caused by incorrect conversion function #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controlplane.Service couldn't be converted to v1beta1.Service directly as it has an extra field. This patch fixes it by using the auto-generated conversion function. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
added
the
kind/cherry-pick
Codecov Report
@@ Coverage Diff @@
## release-0.13 #2312 +/- ##
=================================================
- Coverage 55.99% 33.19% -22.81%
=================================================
Files 201 185 -16
Lines 17304 15905 -1399
=================================================
- Hits 9690 5279 -4411
- Misses 6571 9958 +3387
+ Partials 1043 668 -375
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
antoninbas
approved these changes
Jun 25, 2021
|
Currently upgrade tests doesn't work for release branches. I did manual upgrade test from v0.11.4 and v0.12.3 to v0.13.2-3f9b0335, all succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #2302 on release-0.13.
#2302: Fix MarshalJSON error caused by incorrect conversion function
For details on the cherry pick process, see the cherry pick requests page.