-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement garbage collector for IP Pools #3672
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3672 +/- ##
==========================================
+ Coverage 63.56% 64.84% +1.27%
==========================================
Files 278 278
Lines 39360 39547 +187
==========================================
+ Hits 25020 25643 +623
+ Misses 12420 11917 -503
- Partials 1920 1987 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test-e2e |
/test-flexible-ipam-e2e |
/test-e2e |
I think garbage collector interval should be increased (1 min in this PR), would appreciate feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think we can do every 10 mins.
Agree with Jianjun. 10min is OK. |
Thank you, increased to 10min. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
@annakhm there is a unit test failure. |
|
/test-all |
/test-e2e |
/test-all |
A periodic task would go over all IP Pools and clean up all allocations and reservations for which owner no longer exists in k8s. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
/test-e2e |
/test-flexible-ipam-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-conformance |
A periodic task would go over all IP Pools and clean up
all allocations and reservations for which owner no longer
exists in k8s.
Signed-off-by: Anna Khmelnitsky akhmelnitsky@vmware.com