Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3700: Determine conformance container image version at runtime #3701: Use default dnsPolicy for AKS #3718

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Apr 29, 2022

Cherry pick of #3700 #3701 on release-1.2.

#3700: Determine conformance container image version at runtime
#3701: Use default dnsPolicy for AKS

For details on the cherry pick process, see the cherry pick requests page.

Since Sonobuoy 0.20, Sonobuoy releases are no longer attached to
Kubernetes releases and can determine the images at runtime according to
the Kubernetes server's version. This patch removes pinned K8s test
image versions to fix compatability issues caused by version skew.

Signed-off-by: Quan Tian <qtian@vmware.com>
AKS overrides KUBERNETES_SERVICE_HOST with a FQDN value. Using
ClusterFirstWithHostNet would lead to antrea-agent start failure.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Apr 29, 2022
@tnqn
Copy link
Member Author

tnqn commented Apr 29, 2022

/test-conformance
/test-networkpolicy
/skip-e2e

@tnqn tnqn requested a review from xliuxu April 29, 2022 12:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #3718 (7fd921f) into release-1.2 (8a9884a) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.2    #3718      +/-   ##
===============================================
- Coverage        60.52%   60.43%   -0.09%     
===============================================
  Files              285      285              
  Lines            22455    22455              
===============================================
- Hits             13591    13571      -20     
- Misses            7423     7444      +21     
+ Partials          1441     1440       -1     
Flag Coverage Δ
kind-e2e-tests 46.78% <ø> (-0.08%) ⬇️
unit-tests 42.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/controller/traceflow/packetin.go 59.49% <0.00%> (-5.49%) ⬇️
pkg/controller/networkpolicy/status_controller.go 72.90% <0.00%> (-3.88%) ⬇️
...agent/controller/traceflow/traceflow_controller.go 69.61% <0.00%> (-3.54%) ⬇️
...gent/controller/networkpolicy/status_controller.go 78.08% <0.00%> (-2.74%) ⬇️
pkg/controller/traceflow/controller.go 69.27% <0.00%> (-2.41%) ⬇️
pkg/agent/controller/networkpolicy/reconciler.go 76.81% <0.00%> (-0.24%) ⬇️
pkg/agent/agent.go 50.22% <0.00%> (+0.22%) ⬆️
pkg/agent/openflow/client.go 58.51% <0.00%> (+0.71%) ⬆️
pkg/agent/openflow/pipeline.go 72.91% <0.00%> (+0.93%) ⬆️

Copy link
Contributor

@xliuxu xliuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member Author

tnqn commented Apr 29, 2022

/skip-networkpolicy
/skip-conformance
verified manually

@tnqn tnqn merged commit 89e514f into antrea-io:release-1.2 Apr 29, 2022
@tnqn tnqn deleted the automated-cherry-pick-of-#3700-#3701-upstream-release-1.2 branch April 29, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants