[e2e][flexible-ipam] Fix TestPrometheus failed #3868
Conversation
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #3868 +/- ##
===========================================
- Coverage 64.30% 44.73% -19.58%
===========================================
Files 288 255 -33
Lines 41252 37810 -3442
===========================================
- Hits 26527 16914 -9613
- Misses 12596 19180 +6584
+ Partials 2129 1716 -413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-flexible-ipam-e2e |
|
/test-flexible-ipam-e2e |
| } | ||
| defer resp.Body.Close() | ||
| var body []byte | ||
| err = wait.PollImmediate(defaultInterval, defaultTimeout, func() (bool, error) { |
There was a problem hiding this comment.
How long is defaultTimeout? Does the transient failure happen only in flexible IPAM tests? Do we know why?
There was a problem hiding this comment.
Please add some comments to explain why we do retry here.
There was a problem hiding this comment.
defaultTimeout is 90s, but actually 10s is enough for this case. Just use the default value as other cases.
This failure appears in flexible-ipam-e2e two weeks ago. Still not located the changes caused this issue since this issue occurs intermittently.
Added comment for 3 cases I want to fix in this PR.
There was a problem hiding this comment.
Do you believe we should root cause the failure? If so, please add comments.
Signed-off-by: gran <gran@vmware.com>
|
/test-all |
|
/test-flexible-ipam-e2e |
|
/test-e2e |
Add retry to TestPrometheus to solve intermittent failure.
Signed-off-by: gran gran@vmware.com