License format and package version updates #3919
Conversation
|
/test-multicluster-dataplane-e2e |
Codecov Report
@@ Coverage Diff @@
## main #3919 +/- ##
===========================================
- Coverage 64.24% 53.36% -10.89%
===========================================
Files 293 415 +122
Lines 43227 60353 +17126
===========================================
+ Hits 27772 32208 +4436
- Misses 13232 25508 +12276
- Partials 2223 2637 +414
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -82,7 +83,7 @@ else | |||
| endif | |||
| ##@ Build | |||
|
|
|||
| build: generate fmt vet ## Build manager binary. | |||
There was a problem hiding this comment.
is that change intentional?
There was a problem hiding this comment.
Yes, it's unnecessary to rerun this every time to build a binary in most cases. We should run make codegen to update related codes if it's necessary or run make generate If it's required to update deep copy file only.
| @@ -60,5 +59,8 @@ $GOPATH/bin/informer-gen \ | |||
| --output-package "${ANTREA_PKG}/multicluster/pkg/client/informers" \ | |||
| --go-header-file hack/boilerplate.go.txt | |||
|
|
|||
| go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.4.1 | |||
There was a problem hiding this comment.
shouldn't this be added to the Docker image instead?
There was a problem hiding this comment.
yes, I think we can, let me refine this, thanks.
luolanzone
force-pushed
the
mc-trivial
branch
2 times, most recently
from
33d3e33
to
653dd0e
Compare
|
/test-multicluster-dataplane-e2e |
|
@luolanzone I have built and pushed |
1. Update the license format in auto-generated deepcopy file and let it be updated by `make codegen` 2. Update controller-runtime version to v0.12.1 3. Update controller-gen version to v0.9.0 4. Update codegen image to kubernetes-1.24.0-build.0 Signed-off-by: Lan Luo <luola@vmware.com>
|
@antoninbas I have updated corresponding files and commit/PR messages, Could you help to take a look? thanks. |
|
/test-multicluster-e2e |
|
/skip-all |
make codegenSigned-off-by: Lan Luo luola@vmware.com