Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipv6] Add GratuitousNDP for Pod creation #3998

Merged
merged 1 commit into from
Jul 15, 2022
Merged

[ipv6] Add GratuitousNDP for Pod creation #3998

merged 1 commit into from
Jul 15, 2022

Conversation

gran-vmv
Copy link
Contributor

Signed-off-by: gran gran@vmware.com

@gran-vmv gran-vmv added this to the Antrea v1.8 release milestone Jul 13, 2022
@gran-vmv gran-vmv self-assigned this Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #3998 (fd9a9dd) into main (23ef6f7) will increase coverage by 0.07%.
The diff coverage is 27.77%.

❗ Current head fd9a9dd differs from pull request most recent head 4e427c4. Consider uploading reports for the commit 4e427c4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3998      +/-   ##
==========================================
+ Coverage   64.56%   64.64%   +0.07%     
==========================================
  Files         295      296       +1     
  Lines       43838    43915      +77     
==========================================
+ Hits        28303    28387      +84     
- Misses      13248    13254       +6     
+ Partials     2287     2274      -13
Flag Coverage Δ *Carryforward flag
e2e-tests 41.09% <11.42%> (?)
kind-e2e-tests 51.09% <75.00%> (-0.14%) ⬇️ Carriedforward from 42162ce
unit-tests 44.26% <0.00%> (-0.02%) ⬇️ Carriedforward from 42162ce

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/util/ndp/ndp.go 0.00% <0.00%> (ø)
...g/agent/cniserver/interface_configuration_linux.go 19.50% <62.50%> (+2.30%) ⬆️
.../agent/flowexporter/priorityqueue/priorityqueue.go 60.75% <0.00%> (-32.58%) ⬇️
pkg/agent/openflow/pod_connectivity.go 66.29% <0.00%> (-16.86%) ⬇️
pkg/agent/memberlist/cluster.go 71.24% <0.00%> (-2.88%) ⬇️
...g/agent/controller/serviceexternalip/controller.go 79.18% <0.00%> (-2.39%) ⬇️
pkg/agent/route/route_linux.go 45.09% <0.00%> (-2.02%) ⬇️
pkg/controller/grouping/controller.go 65.13% <0.00%> (-1.98%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 79.45% <0.00%> (-1.37%) ⬇️
pkg/agent/ipassigner/ip_assigner_linux.go 46.19% <0.00%> (-1.09%) ⬇️
... and 31 more

@gran-vmv
Copy link
Contributor Author

/test-windows-proxyall-e2e

xliuxu
xliuxu reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@xliuxu xliuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have NDP utils in pkg/agent/util/ndp/ndp_linux.go?

@gran-vmv
Copy link
Contributor Author

/test-ipv6-e2e
/test-ipv6-networkpolicy

@gran-vmv
Copy link
Contributor Author

I think we already have NDP utils in pkg/agent/util/ndp/ndp_linux.go?

Yes, I moved this file to pkg/agent/util/ndp and I think we should keep this method because this method is simpler and supports Windows.

@gran-vmv
Copy link
Contributor Author

/test-all
/test-ipv6-all
/test-ipv6-only-all

@gran-vmv
Copy link
Contributor Author

/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy

@gran-vmv
Copy link
Contributor Author

/test-windows-all
/test-multicluster-e2e
/test-flexible-ipam-e2e

jianjuns
jianjuns reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

pkg/agent/util/ndp/ndp.go Outdated
"github.com/mdlayher/ndp"
)

// GratuitousNDPOverIface sends an gratuitous NDP over interface 'iface' from 'srcIP'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from iface using srcIP as the source IP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

pkg/agent/util/ndp/ndp.go Outdated

// GratuitousNDPOverIface sends an gratuitous NDP over interface 'iface' from 'srcIP'.
func GratuitousNDPOverIface(srcIP net.IP, iface *net.Interface) error {
ipv4 := srcIP.To4()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: if srcIP.To4() != nil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a gratuitous NDP"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. FIxed.

@gran-vmv
[ipv6] Add GratuitousNDP for Pod creation
4e427c4 
Signed-off-by: gran <gran@vmware.com>
@gran-vmv
Copy link
Contributor Author

/test-all
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all

@gran-vmv
Copy link
Contributor Author

/test-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy
/test-windows-networkpolicy

@jianjuns jianjuns merged commit 675c015 into antrea-io:main Jul 15, 2022
@tnqn tnqn mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xliuxu xliuxu xliuxu left review comments

@jianjuns jianjuns jianjuns approved these changes

@antoninbas antoninbas Awaiting requested review from antoninbas

@wenyingd wenyingd Awaiting requested review from wenyingd

@tnqn tnqn Awaiting requested review from tnqn

Assignees

@gran-vmv gran-vmv

Labels
None yet
Projects
None yet
Milestone
Antrea v1.8 release
Development

Successfully merging this pull request may close these issues.
3 participants
@gran-vmv @jianjuns @xliuxu