Remove MemberClusterAnnounce if ClusterSet deleted #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## main #4026 +/- ##
==========================================
+ Coverage 64.34% 65.96% +1.62%
==========================================
Files 294 309 +15
Lines 43634 44125 +491
==========================================
+ Hits 28076 29107 +1031
+ Misses 13282 12693 -589
- Partials 2276 2325 +49
*This pull request uses carry forward flags. Click here to find out more.
|
luolanzone
force-pushed
the
memberclusterannounce-cleanup
branch
from
0f5abfe
to
390dc13
Compare
|
/test-multicluster-e2e |
jianjuns
reviewed
Jul 18, 2022
| @@ -92,6 +92,9 @@ func (r *MemberClusterSetReconciler) Reconcile(ctx context.Context, req ctrl.Req | |||
| } | |||
| klog.InfoS("Received ClusterSet delete", "clusterset", req.NamespacedName) | |||
| if r.remoteCommonArea != nil { | |||
| if err := r.deleteMemberClusterAnnounce(ctx); err != nil { | |||
| return ctrl.Result{}, err | |||
There was a problem hiding this comment.
I think you need to prepend context to the returned err (or log the failure with context here), otherwise the log by the caller wont indicate what fails.
e.g. fmt.Errorf("failed to delete MemberClusterAnnounce in the leader cluster: %v", err)
Add a step to ensure that member ClusterSet controller will clean up MemberClusterAnnounce in the leader cluster if the ClusterSet in the member is deleted. Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
memberclusterannounce-cleanup
branch
from
390dc13
to
3afba07
Compare
jianjuns
approved these changes
Jul 19, 2022
|
/test-multicluster-e2e |
jianjuns
approved these changes
Jul 21, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a step to ensure that member ClusterSet controller will
clean up MemberClusterAnnounce in the leader cluster if
the ClusterSet in the member is deleted.