Fix unit tests that rely on pseudo-random numbers #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4148 +/- ##
==========================================
+ Coverage 66.00% 66.65% +0.65%
==========================================
Files 304 304
Lines 46619 47252 +633
==========================================
+ Hits 30769 31494 +725
+ Misses 13443 13323 -120
- Partials 2407 2435 +28
|
Test_ofPacketOutBuilder_Done relies on specific pseudo-random numbers to be generated and will fail if another test also calls the pseudo-random number generator. This patch creates a dedicated random number generator for ofPacketOutBuilder and specifies a hardcoded seed for unit tests to make test outputs predictable. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
force-pushed
the
unit-test-random-value
branch
from
7b92a1e
to
aaad71d
Compare
|
/test-all |
wenqiq
pushed a commit
to wenqiq/antrea
that referenced
this pull request
Oct 18, 2022
Test_ofPacketOutBuilder_Done relies on specific pseudo-random numbers to be generated and will fail if another test also calls the pseudo-random number generator. This patch creates a dedicated random number generator for ofPacketOutBuilder and specifies a hardcoded seed for unit tests to make test outputs predictable. Signed-off-by: Quan Tian <qtian@vmware.com>
wenqiq
pushed a commit
to wenqiq/antrea
that referenced
this pull request
Oct 19, 2022
Test_ofPacketOutBuilder_Done relies on specific pseudo-random numbers to be generated and will fail if another test also calls the pseudo-random number generator. This patch creates a dedicated random number generator for ofPacketOutBuilder and specifies a hardcoded seed for unit tests to make test outputs predictable. Signed-off-by: Quan Tian <qtian@vmware.com>
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
Test_ofPacketOutBuilder_Done relies on specific pseudo-random numbers to be generated and will fail if another test also calls the pseudo-random number generator. This patch creates a dedicated random number generator for ofPacketOutBuilder and specifies a hardcoded seed for unit tests to make test outputs predictable. Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test_ofPacketOutBuilder_Done relies on specific pseudo-random numbers to
be generated and will fail if another test also calls the pseudo-random
number generator. This patch creates a dedicated random number generator
for ofPacketOutBuilder and specifies a hardcoded seed for unit tests to
make test outputs predictable.
Signed-off-by: Quan Tian qtian@vmware.com