Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Flow Aggregator API handlers #4179

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

yanjunz97
Copy link
Contributor

For #4142

Signed-off-by: Yanjun Zhou zhouya@vmware.com

Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #4179 (7e03a54) into main (222c2b6) will decrease coverage by 6.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4179      +/-   ##
==========================================
- Coverage   66.31%   60.12%   -6.20%     
==========================================
  Files         304      380      +76     
  Lines       46613    53791    +7178     
==========================================
+ Hits        30911    32341    +1430     
- Misses      13296    19036    +5740     
- Partials     2406     2414       +8     
Flag Coverage Δ
integration-tests 34.97% <ø> (+0.07%) ⬆️
kind-e2e-tests 49.09% <0.00%> (-0.16%) ⬇️
unit-tests 41.18% <0.00%> (-4.07%) ⬇️
Impacted Files Coverage Δ
...egator/apiserver/handlers/recordmetrics/handler.go 68.00% <0.00%> (+28.00%) ⬆️
...nt/apiserver/handlers/serviceexternalip/handler.go 37.03% <0.00%> (-14.82%) ⬇️
pkg/agent/flowexporter/utils.go 72.34% <0.00%> (-8.52%) ⬇️
pkg/controller/networkpolicy/tier.go 50.00% <0.00%> (-5.00%) ⬇️
pkg/agent/util/ipset/ipset.go 69.23% <0.00%> (-2.57%) ⬇️
pkg/controller/networkpolicy/store/addressgroup.go 88.37% <0.00%> (-2.33%) ⬇️
pkg/controller/grouping/controller.go 65.13% <0.00%> (-1.98%) ⬇️
pkg/agent/controller/networkpolicy/reconciler.go 70.27% <0.00%> (-1.94%) ⬇️
pkg/controller/networkpolicy/status_controller.go 68.56% <0.00%> (-1.14%) ⬇️
pkg/agent/ipassigner/ip_assigner_linux.go 55.97% <0.00%> (-1.09%) ⬇️
... and 142 more

@yanjunz97 yanjunz97 requested a review from tnqn August 30, 2022 22:53
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tnqn
Copy link
Member

tnqn commented Aug 31, 2022

/skip-all

@tnqn tnqn mentioned this pull request Aug 31, 2022
37 tasks
@tnqn tnqn merged commit 7a3f6e2 into antrea-io:main Aug 31, 2022
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants