Add antcl mc commands to get/delete member token #4254

bangqipropel · 2022-09-28T18:27:34Z

Add 2 new commands for the users to fetch and delete tokens.

antctl mc get membertoken: to fetch a member token, and print them out or write it in a file
antctl mc delete membertoken: to delete a member token and also the RoleBinding and ServiceAccount of it.

added the unit-test of these tokens and the relation functions

Resolve #4255

codecov · 2022-09-28T18:44:42Z

Codecov Report

Merging #4254 (ffff951) into main (b1d3ba9) will increase coverage by 0.71%.
The diff coverage is 71.78%.

@@            Coverage Diff             @@
##             main    #4254      +/-   ##
==========================================
+ Coverage   64.35%   65.07%   +0.71%     
==========================================
  Files         390      405      +15     
  Lines       55316    55591     +275     
==========================================
+ Hits        35597    36174     +577     
+ Misses      17127    16805     -322     
- Partials     2592     2612      +20

Flag	Coverage Δ
e2e-tests	`41.32% <ø> (?)`
integration-tests	`34.56% <ø> (-0.01%)`	⬇️
kind-e2e-tests	`48.82% <ø> (-0.49%)`	⬇️
unit-tests	`48.14% <71.78%> (+0.12%)`	⬆️

Impacted Files	Coverage Δ
pkg/antctl/antctl.go	`50.00% <ø> (ø)`
pkg/antctl/raw/multicluster/get/clusterset.go	`83.11% <ø> (ø)`
pkg/antctl/raw/multicluster/get/member_token.go	`55.55% <55.55%> (ø)`
pkg/antctl/raw/multicluster/common/common.go	`74.19% <75.58%> (-0.53%)`	⬇️
pkg/antctl/raw/multicluster/delete/member_token.go	`78.37% <78.37%> (ø)`
pkg/antctl/transform/membertoken/transform.go	`89.28% <89.28%> (ø)`
pkg/antctl/raw/multicluster/commands.go	`100.00% <100.00%> (ø)`
pkg/antctl/raw/multicluster/create/member_token.go	`79.62% <100.00%> (ø)`
pkg/antctl/transform/clusterset/transform.go	`100.00% <100.00%> (ø)`
pkg/agent/cniserver/ipam/antrea_ipam.go	`51.08% <0.00%> (-24.68%)`	⬇️
... and 55 more

join.yml

pkg/antctl/raw/multicluster/commands.go

pkg/antctl/raw/multicluster/get/token.go

pkg/antctl/raw/multicluster/common/common.go

pkg/antctl/raw/multicluster/common/common_test.go

bangqipropel · 2022-10-10T22:02:09Z

good for review again, thanks! @luolanzone

bangqipropel · 2022-10-12T08:00:06Z

@luolanzone added Jianjun's MR part, thanks!

pkg/antctl/raw/multicluster/common/common.go

pkg/antctl/raw/multicluster/delete/member_token.go

pkg/antctl/raw/multicluster/get/member_token.go

pkg/antctl/raw/multicluster/get/member_token_test.go

pkg/antctl/raw/multicluster/commands.go

pkg/antctl/raw/multicluster/get/member_token.go

pkg/antctl/raw/multicluster/delete/member_token.go

pkg/antctl/raw/multicluster/common/common.go

luolanzone · 2022-10-17T05:47:08Z

@bangqipropel please don't forget to update the antctl.md document.

lgtm-com · 2022-10-17T10:32:52Z

This pull request introduces 1 alert when merging 8bf8f2f into 549e0fb - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

jianjuns

Have not finished review yet. Will continue.

docs/multicluster/antctl.md

pkg/antctl/raw/multicluster/get/member_token.go

pkg/antctl/raw/multicluster/delete/member_token.go

pkg/antctl/transform/member_token/transform.go

pkg/antctl/raw/multicluster/get/member_token.go

pkg/antctl/raw/multicluster/common/common.go

bangqipropel · 2022-10-18T21:59:50Z

@jianjuns comments addressed, thanks!

jianjuns

LGTM

luolanzone · 2022-10-19T01:22:34Z

pkg/antctl/transform/member_token/transform.go

@@ -0,0 +1,61 @@
+// Copyright 2022 Antrea Authors


The directory should be renamed as well.

pkg/antctl/raw/multicluster/get/member_token.go

luolanzone

LGTM overall

jianjuns · 2022-10-19T16:36:01Z

/test-all

bangqipropel · 2022-10-19T19:05:40Z

/test-all

jianjuns · 2022-10-19T19:07:40Z

/test-multicluster-e2e

Signed-off-by: Bangqi Zhu <zbangqi@vmware.com>

bangqipropel · 2022-10-19T20:51:21Z

/test-all

bangqipropel · 2022-10-19T20:51:30Z

/test-multicluster-e2e

Add 2 new commands for the users to fetch and delete Multi-cluster ClusterSet member tokens. antctl mc get membertoken: to fetch a member token, and print them out or write it in a file antctl mc delete membertoken: to delete a member token and also the RoleBinding and ServiceAccount of it. Signed-off-by: Bangqi Zhu <zbangqi@vmware.com>

bangqipropel force-pushed the fetch_and_delete branch 5 times, most recently from 1f8cb91 to 6fbe1dc Compare September 29, 2022 02:14

bangqipropel changed the title ~~fetch and delete token command line~~ Fetch and delete token command line Sep 29, 2022

luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Sep 29, 2022

bangqipropel force-pushed the fetch_and_delete branch from 6fbe1dc to 3ff3a33 Compare September 29, 2022 04:14

bangqipropel requested review from hjiajing and luolanzone September 30, 2022 02:57

luolanzone reviewed Sep 30, 2022

View reviewed changes

bangqipropel force-pushed the fetch_and_delete branch 2 times, most recently from 5c81866 to 0132533 Compare October 10, 2022 18:02

bangqipropel requested a review from luolanzone October 11, 2022 03:45

bangqipropel force-pushed the fetch_and_delete branch from 0132533 to 287a501 Compare October 12, 2022 07:21

luolanzone requested a review from jianjuns October 12, 2022 09:10

luolanzone added this to the Antrea v1.9 release milestone Oct 12, 2022

luolanzone reviewed Oct 12, 2022

View reviewed changes

jianjuns reviewed Oct 13, 2022

View reviewed changes

jianjuns mentioned this pull request Oct 17, 2022

Add antctl mc command to print ClusterSet join parameters #4299

Merged

bangqipropel force-pushed the fetch_and_delete branch 2 times, most recently from ef9e6e0 to 8bf8f2f Compare October 17, 2022 10:09

bangqipropel force-pushed the fetch_and_delete branch from 8bf8f2f to c39867c Compare October 17, 2022 17:12

jianjuns reviewed Oct 17, 2022

View reviewed changes

bangqipropel force-pushed the fetch_and_delete branch 2 times, most recently from baae576 to 956fa1d Compare October 18, 2022 20:58

jianjuns previously approved these changes Oct 18, 2022

View reviewed changes

luolanzone reviewed Oct 19, 2022

View reviewed changes

bangqipropel dismissed jianjuns’s stale review via 9004b2d October 19, 2022 03:16

bangqipropel force-pushed the fetch_and_delete branch from 956fa1d to 9004b2d Compare October 19, 2022 03:16

luolanzone reviewed Oct 19, 2022

View reviewed changes

pkg/antctl/raw/multicluster/get/member_token.go Show resolved Hide resolved

luolanzone reviewed Oct 19, 2022

View reviewed changes

pkg/antctl/raw/multicluster/get/member_token.go Show resolved Hide resolved

pkg/antctl/raw/multicluster/get/member_token.go Outdated Show resolved Hide resolved

bangqipropel force-pushed the fetch_and_delete branch 3 times, most recently from 2cf666e to 6bc65fc Compare October 19, 2022 05:42

luolanzone previously approved these changes Oct 19, 2022

View reviewed changes

bangqipropel dismissed luolanzone’s stale review via 722dd2c October 19, 2022 19:00

bangqipropel force-pushed the fetch_and_delete branch from 6bc65fc to 722dd2c Compare October 19, 2022 19:00

jianjuns previously approved these changes Oct 19, 2022

View reviewed changes

fetch and delete token command line

ffff951

Signed-off-by: Bangqi Zhu <zbangqi@vmware.com>

bangqipropel dismissed jianjuns’s stale review via ffff951 October 19, 2022 20:49

bangqipropel force-pushed the fetch_and_delete branch from 722dd2c to ffff951 Compare October 19, 2022 20:49

jianjuns approved these changes Oct 19, 2022

View reviewed changes

jianjuns changed the title ~~Fetch and delete token command line~~ Add antcl mc commands to get/delete member token Oct 19, 2022

jianjuns merged commit 14e0dda into main Oct 20, 2022

jianjuns deleted the fetch_and_delete branch October 20, 2022 00:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add antcl mc commands to get/delete member token #4254

Add antcl mc commands to get/delete member token #4254

bangqipropel commented Sep 28, 2022 •

edited by luolanzone

Loading

codecov bot commented Sep 28, 2022 •

edited

Loading

bangqipropel commented Oct 10, 2022 •

edited

Loading

bangqipropel commented Oct 12, 2022

luolanzone commented Oct 17, 2022

lgtm-com bot commented Oct 17, 2022

jianjuns left a comment

bangqipropel commented Oct 18, 2022

jianjuns left a comment

luolanzone Oct 19, 2022

luolanzone left a comment

jianjuns commented Oct 19, 2022

bangqipropel commented Oct 19, 2022

jianjuns commented Oct 19, 2022

bangqipropel commented Oct 19, 2022

bangqipropel commented Oct 19, 2022

Add antcl mc commands to get/delete member token #4254

Add antcl mc commands to get/delete member token #4254

Conversation

bangqipropel commented Sep 28, 2022 • edited by luolanzone Loading

codecov bot commented Sep 28, 2022 • edited Loading

Codecov Report

bangqipropel commented Oct 10, 2022 • edited Loading

bangqipropel commented Oct 12, 2022

luolanzone commented Oct 17, 2022

lgtm-com bot commented Oct 17, 2022

jianjuns left a comment

Choose a reason for hiding this comment

bangqipropel commented Oct 18, 2022

jianjuns left a comment

Choose a reason for hiding this comment

luolanzone Oct 19, 2022

Choose a reason for hiding this comment

luolanzone left a comment

Choose a reason for hiding this comment

jianjuns commented Oct 19, 2022

bangqipropel commented Oct 19, 2022

jianjuns commented Oct 19, 2022

bangqipropel commented Oct 19, 2022

bangqipropel commented Oct 19, 2022

bangqipropel commented Sep 28, 2022 •

edited by luolanzone

Loading

codecov bot commented Sep 28, 2022 •

edited

Loading

bangqipropel commented Oct 10, 2022 •

edited

Loading