Fix an issue when generating ExternalEntity from ExternalNode #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4259 +/- ##
==========================================
- Coverage 61.30% 59.61% -1.69%
==========================================
Files 388 378 -10
Lines 55145 54682 -463
==========================================
- Hits 33806 32601 -1205
- Misses 18799 19621 +822
+ Partials 2540 2460 -80
|
wenyingd
force-pushed
the
externalentity_owner_apiversion
branch
from
a43990b
to
04e0766
Compare
tnqn
reviewed
Sep 30, 2022
wenyingd
force-pushed
the
externalentity_owner_apiversion
branch
from
04e0766
to
8797d1f
Compare
wenyingd
force-pushed
the
externalentity_owner_apiversion
branch
from
8797d1f
to
08f3a80
Compare
tnqn
reviewed
Oct 12, 2022
| ExternalNode: "vm1", | ||
| }, | ||
| } | ||
| testDeleteExternalNode(t, externalNode, expectedEntity) |
There was a problem hiding this comment.
same as testAddExternalNode, separting input and test code makes the test less readable.
| informerFactory.WaitForCacheSync(stopCh) | ||
| err := controller.reconcileExternalNodes() | ||
| require.NoError(t, err) | ||
| err = wait.PollImmediate(time.Millisecond*50, time.Second, func() (done bool, err error) { |
There was a problem hiding this comment.
Unlike other tests that rely on Run method to create/delete objects asynchronously, reconcileExternalNodes does everything synchronously, I think it should do the following check immediately and one-time?
wenyingd
force-pushed
the
externalentity_owner_apiversion
branch
from
08f3a80
to
717d13b
Compare
wenyingd
force-pushed
the
externalentity_owner_apiversion
branch
from
717d13b
to
45548ac
Compare
1. Use group/apiversion for ownerreference when creating ExternalEntity from ExternalNode 2. Add unit tests for ExternalNodeController Signed-off-by: wenyingd <wenyingd@vmware.com>
wenyingd
force-pushed
the
externalentity_owner_apiversion
branch
from
45548ac
to
944620d
Compare
|
/test-all |
tnqn
added
the
action/release-note
mengdie-song
approved these changes
Oct 17, 2022
|
The unit test failure is a known issue on main branch: #4294, no need to rerun. |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
…-io#4259) 1. Use group/apiversion for ownerreference when creating ExternalEntity from ExternalNode 2. Add unit tests for ExternalNodeController Signed-off-by: wenyingd <wenyingd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wenyingd wenyingd@vmware.com