Delete Pod specific VF resource cache from Podwatch controller, when a Pod gets deleted. #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4285 +/- ##
==========================================
+ Coverage 63.16% 64.29% +1.13%
==========================================
Files 388 393 +5
Lines 55147 55548 +401
==========================================
+ Hits 34833 35714 +881
+ Misses 17766 17224 -542
- Partials 2548 2610 +62
|
antoninbas
reviewed
Oct 13, 2022
| podKey := podNamespace + "/" + podName | ||
| _, cacheFound := pc.vfDeviceIDUsageMap.Load(podKey) | ||
| if cacheFound { | ||
| klog.InfoS("Pod specific VF Cache cleared for ", "pod", podKey) |
There was a problem hiding this comment.
this should be
klog.InfoS("Pod specific VF cache cleared", "key", podKey)But if you want to have this log message, I think the verbosity needs to be changed (e.g., to V(2)). It is also surprising that we have a log message for the deletion case but not when the cache entry is created or modified.
| @@ -290,6 +300,8 @@ func (pc *PodController) handleRemovePod(key string) error { | |||
| } else { | |||
| // Delete cache entry from podCNIInfo. | |||
| pc.podCache.DeleteCNIConfigInfo(containerInfo) | |||
| // Delete Pod specific VF cache (if one exist) | |||
arunvelayutham
force-pushed
the
fix-to-clear-pod-vf-cache-upon-pod-delete
branch
from
44cc920
to
64b2744
Compare
jianjuns
reviewed
Oct 24, 2022
There was a problem hiding this comment.
@arunvelayutham : I saw irrelevant files in your comments (a.log, a.txt, etc.). Could you please fix?
arunvelayutham
force-pushed
the
fix-to-clear-pod-vf-cache-upon-pod-delete
branch
from
64b2744
to
8afc1fe
Compare
|
@jianjuns looks like a test commit got accidently push (while I was addressing the git issue last week). fix it now. |
…atch controller Signed-off-by: Arunkumar Velayutham <arunkumar.velayutham@intel.com>
arunvelayutham
force-pushed
the
fix-to-clear-pod-vf-cache-upon-pod-delete
branch
2 times, most recently
from
5ae73fa
to
fd2d8c8
Compare
jianjuns
approved these changes
Oct 25, 2022
| @@ -290,6 +301,8 @@ func (pc *PodController) handleRemovePod(key string) error { | |||
| } else { | |||
| // Delete cache entry from podCNIInfo. | |||
| pc.podCache.DeleteCNIConfigInfo(containerInfo) | |||
| // Delete Pod specific VF cache (if one exists) | |||
| pc.deleteVFDeviceIDListPerPod(containerInfo.PodName, containerInfo.PodNameSpace) | |||
There was a problem hiding this comment.
Question - could we pass key argument of handleRemovePod() to deleteVFDeviceIDListPerPod()
There was a problem hiding this comment.
Yes, key from the function argument can be used as well.
|
/test-e2e |
|
/test-networkpolicy |
|
/test-conformance |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Jan 27, 2023
Upon a CNF Pod delete, clear Pod VF cache in the secondary network's podwatch controller. Signed-off-by: Arunkumar Velayutham <arunkumar.velayutham@intel.com>
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
Upon a CNF Pod delete, clear Pod VF cache in the secondary network's podwatch controller. Signed-off-by: Arunkumar Velayutham <arunkumar.velayutham@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Pod gets deleted and recreated, secondary network configuration fails due to misconfigured VF resource cache. Pod specific VF resource must be cleared, when a Pod gets deleted everything.
NOTE: Upon Pod creation, Podwatch controller will build a VF resource cache, if the Pod annotates to configure SRIOV based secondary network interfaces.
Signed-off-by: Arunkumar Velayutham arunkumar.velayutham@intel.com