[Flow Aggregator] Enclose Pod labels with single quote in s3 uploader #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4334 +/- ##
==========================================
- Coverage 64.38% 63.81% -0.58%
==========================================
Files 393 397 +4
Lines 55538 56274 +736
==========================================
+ Hits 35760 35909 +149
- Misses 17188 17758 +570
- Partials 2590 2607 +17
|
dreamtalen
force-pushed
the
fa-sf-label
branch
2 times, most recently
from
6d35188
to
822d486
Compare
In this commit, we updated the s3 uploader inside Flow Aggregator to enclose Pod label fields with single quote for snowflake usecases. Because commas are used to separate different columns in CSV and Pod labels json string contains commas, we enclose it with single quote to avoid them being separated into multiple columns in Snowflake. Signed-off-by: Yongming Ding <dyongming@vmware.com>
dreamtalen
force-pushed
the
fa-sf-label
branch
from
822d486
to
71734d1
Compare
dreamtalen
changed the title
|
/test-all |
antoninbas
approved these changes
Oct 27, 2022
|
/test-e2e |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Jan 27, 2023
In this commit, we updated the s3 uploader inside Flow Aggregator to enclose Pod label fields with single quotes. Because commas are used to separate different columns in CSV and Pod labels json-encoded strings contain commas, we enclose them with single quotes to avoid them being separated into multiple columns when ingested by data warehouses such as Snowflake. Signed-off-by: Yongming Ding <dyongming@vmware.com>
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
In this commit, we updated the s3 uploader inside Flow Aggregator to enclose Pod label fields with single quotes. Because commas are used to separate different columns in CSV and Pod labels json-encoded strings contain commas, we enclose them with single quotes to avoid them being separated into multiple columns when ingested by data warehouses such as Snowflake. Signed-off-by: Yongming Ding <dyongming@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we updated the s3 uploader inside Flow Aggregator to
enclose Pod label fields with single quote for snowflake usecases.
Because commas are used to separate different columns in CSV and Pod
labels json string contains commas, we enclose Pod labels with single quote to
avoid them being separated into multiple columns in Snowflake.
Changes on Theia side: antrea-io/theia#133