Add L7 Antrea native NetworkPolicy support in controller #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4406 +/- ##
==========================================
+ Coverage 63.56% 63.93% +0.37%
==========================================
Files 400 400
Lines 56849 57086 +237
==========================================
+ Hits 36137 36500 +363
+ Misses 18035 17880 -155
- Partials 2677 2706 +29
*This pull request uses carry forward flags. Click here to find out more.
|
tnqn
reviewed
Nov 23, 2022
qiyueyao
force-pushed
the
l7networkpolicy-controller
branch
from
9234e21
to
ed2cb8b
Compare
tnqn
reviewed
Nov 29, 2022
Comment on lines
778
to
779
| if port.Protocol != nil && *port.Protocol != v1.ProtocolTCP { | ||
| return "layer 7 protocols can only be used when layer 4 protocol is TCP or unset", false |
There was a problem hiding this comment.
not all layer 7 protocols are based on TCP, though the only supported protocol http is. To avoid confusion and to be extensible, it should validate the l4 protocol is either unset or TCP if the l7 protocol is http, and the error message should say "HTTP protocol can only be used when layer 4 protocol is TCP or unset"
There was a problem hiding this comment.
Updated for protocols and ports. Added verification for toServices.
qiyueyao
changed the title
qiyueyao
force-pushed
the
l7networkpolicy-controller
branch
from
ed2cb8b
to
3f185d2
Compare
tnqn
reviewed
Nov 30, 2022
qiyueyao
force-pushed
the
l7networkpolicy-controller
branch
2 times, most recently
from
b0d6e2c
to
69a0c9a
Compare
Add support for passing L7Protocols to agent when processing ACNP and ANP. Add validation for Antrea native policy for L7Protocols (HTTP only) to be used with Ports/Protocols, only supports Allow, and not used with toServices. Add UT. Signed-off-by: Qiyue Yao <yaoq@vmware.com>
qiyueyao
force-pushed
the
l7networkpolicy-controller
branch
from
69a0c9a
to
cb81da6
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for L7 Antrea native NetworkPolicy in the controller side.
L7Protocolsto agent when processing ClusterNetworkPolicy and AntreaNetworkPolicy.L7Protocolsis only used withAllowaction, not used withtoServices. WhenHTTPis set, then L4Protocol is onlyTCPor unset, and not withIGMPorICMP.