Reduce confusion caused by transient error encountered creating tiers #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Antrea is newly deployed to a cluster, antrea-controller will create some system tiers but may fail a few times because kube-apiserver couldn't call validating webhook served by antrea-controller itself successfully due to readiness probing delay. The related logs looked confusing as there were only failures and users don't know if they succeed finally. To reduce confusion, the patch uses INFO for the creation failure and indicate explicitly it will retry, and adds a success log. Signed-off-by: Quan Tian <qtian@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4414 +/- ##
==========================================
+ Coverage 65.56% 65.68% +0.11%
==========================================
Files 400 400
Lines 56847 56998 +151
==========================================
+ Hits 37270 37437 +167
+ Misses 16882 16878 -4
+ Partials 2695 2683 -12
|
|
/test-all |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Jan 27, 2023
…antrea-io#4414) When Antrea is newly deployed to a cluster, antrea-controller will create some system tiers but may fail a few times because kube-apiserver couldn't call validating webhook served by antrea-controller itself successfully due to readiness probing delay. The related logs looked confusing as there were only failures and users don't know if they succeed finally. To reduce confusion, the patch uses INFO for the creation failure and indicate explicitly it will retry, and adds a success log. Signed-off-by: Quan Tian <qtian@vmware.com>
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
…antrea-io#4414) When Antrea is newly deployed to a cluster, antrea-controller will create some system tiers but may fail a few times because kube-apiserver couldn't call validating webhook served by antrea-controller itself successfully due to readiness probing delay. The related logs looked confusing as there were only failures and users don't know if they succeed finally. To reduce confusion, the patch uses INFO for the creation failure and indicate explicitly it will retry, and adds a success log. Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Antrea is newly deployed to a cluster, antrea-controller will create some system tiers but may fail a few times because kube-apiserver couldn't call validating webhook served by antrea-controller itself successfully due to readiness probing delay. The related logs looked confusing as there were only failures and users don't know if they succeed finally.
To reduce confusion, the patch uses INFO for the creation failure and indicates explicitly it will retry, and adds a success log.
Signed-off-by: Quan Tian qtian@vmware.com