Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4529: Fix tunnelDstIP field in traceflow on dual-stack #4840

Conversation

luolanzone
Copy link
Contributor

Cherry pick of #4529 on release-1.10.

#4529: Fix tunnelDstIP field in traceflow on dual-stack

For details on the cherry pick process, see the cherry pick requests page.

On dual-stack testbed, Inter-Node traceflow observation for
IPv4 packet in encap mode has empty tunnelDstIP field because
isIPv6 variable is set.

Change the logic to set isIPv6 variable based on the packet
IPv4 or IPv6.

Fixes antrea-io#4502

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Apr 11, 2023
@luolanzone luolanzone requested a review from tnqn April 11, 2023 05:48
@luolanzone
Copy link
Contributor Author

/test-ipv6-e2e

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4840 (a67aaf8) into release-1.10 (2bc6dbd) will increase coverage by 1.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.10    #4840      +/-   ##
================================================
+ Coverage         68.15%   70.07%   +1.91%     
================================================
  Files               404      380      -24     
  Lines             58295    56044    -2251     
================================================
- Hits              39731    39271     -460     
+ Misses            15813    14062    -1751     
+ Partials           2751     2711      -40     
Flag Coverage Δ *Carryforward flag
integration-tests 34.54% <ø> (-0.06%) ⬇️
kind-e2e-tests 48.05% <ø> (-0.01%) ⬇️ Carriedforward from 2bc6dbd
unit-tests 58.41% <100.00%> (+1.43%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/controller/traceflow/packetin.go 67.46% <100.00%> (+0.08%) ⬆️

... and 36 files with indirect coverage changes

@tnqn
Copy link
Member

tnqn commented Apr 11, 2023

/skip-all

@tnqn tnqn merged commit cbe3a8b into antrea-io:release-1.10 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants