Supplyment multicast document with a limitation #4850

ceclinux · 2023-04-12T08:22:37Z

Document the limitation of a large number of receiver groups in one node for multicast.

wenyingd · 2023-04-13T10:04:24Z

docs/multicast-guide.md

+### Large number of receiver groups for one node
+
+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the number of [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).


Append "The default value is 20." after this sentence.

wenyingd · 2023-04-13T10:05:17Z

docs/multicast-guide.md

+
+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the number of [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).
+Users should change this number according to their needs, and Antrea is not


Remove "and Antrea is not responsible for changing it."

wenyingd · 2023-04-13T10:07:19Z

docs/multicast-guide.md

+
+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the number of [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).
+Users should change this number according to their needs, and Antrea is not


Suggested change

Users should change this number according to their needs, and Antrea is not

Users are responsible to change the value if more than 20 multicast groups are expected per Node.

updated. I think the correct wording should be "responsible for" https://www.britannica.com/dictionary/eb/qa/What-preposition-should-be-used-after-responsible-

wenyingd

LGTM

luolanzone · 2023-04-14T04:23:16Z

docs/multicast-guide.md

@@ -137,6 +137,13 @@ Support for Windows and IPv6 will be added in the future.
 Configuration option `multicastInterfaces` is not supported with encap mode.
 Multicast packets in encap mode are SNATed and forwarded to the transport interface only.

+### Large number of receiver groups for one node


Suggested change

### Large number of receiver groups for one node

### Large number of receiver groups for one Node

luolanzone · 2023-04-14T04:29:44Z

docs/multicast-guide.md

+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).


Better to say:

Suggested change

A Linux host limits the maximum number of multicast groups it can subscribe to

by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).

A Linux host limits the maximum number of multicast groups it can subscribe to,

the default number is 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).

I think your suggestion is grammatically incorrect. A Linux host limits the maximum number of multicast groups it can subscribe to, the default number is 20 contains two independent clauses, and they are improperly joined with a comma.

Maybe: "A Linux host limits the maximum number of multicast groups it can subscribe to; the default number is 20. The limit can be changed by setting /proc/sys/net/ipv4/igmp_max_memberships."?

@ceclinux you can follow @jianjuns 's suggestion to refine the sentence, the purpose is to make the sentence more readable.

updated. Thanks

luolanzone · 2023-04-14T04:31:39Z

docs/multicast-guide.md

+
+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).
+Users are responsible for changing the value if Pods on this Node are expected to


Suggested change

Users are responsible for changing the value if Pods on this Node are expected to

Users are responsible to change the value if Pods on the Node are expected to

"for changing" is correct.

Maybe change "the value" to "the limit".

jianjuns · 2023-04-14T17:48:46Z

docs/multicast-guide.md

@@ -137,6 +137,13 @@ Support for Windows and IPv6 will be added in the future.
 Configuration option `multicastInterfaces` is not supported with encap mode.
 Multicast packets in encap mode are SNATed and forwarded to the transport interface only.

+### Large number of receiver groups for one node


"Maximum number of receiver groups on one Node"?

jianjuns · 2023-04-14T17:52:15Z

docs/multicast-guide.md

+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).


Maybe: "A Linux host limits the maximum number of multicast groups it can subscribe to; the default number is 20. The limit can be changed by setting /proc/sys/net/ipv4/igmp_max_memberships."?

jianjuns · 2023-04-14T17:52:56Z

docs/multicast-guide.md

+
+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).
+Users are responsible for changing the value if Pods on this Node are expected to


"for changing" is correct.

jianjuns · 2023-04-14T17:53:16Z

docs/multicast-guide.md

+
+A Linux host limits the maximum number of multicast groups it can subscribe to
+by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).
+Users are responsible for changing the value if Pods on this Node are expected to


Maybe change "the value" to "the limit".

Document the limitation of a large number of receiver groups in one node for multicast. Signed-off-by: ceclinux <src655@gmail.com>

wenyingd · 2023-04-18T03:21:49Z

/skip-all

wenyingd

LGTM

ceclinux added the kind/documentation Categorizes issue or PR as related to a documentation. label Apr 12, 2023

wenyingd reviewed Apr 13, 2023

View reviewed changes

ceclinux force-pushed the document-igmp_max_memberships-for-multicast branch 3 times, most recently from cb0fecf to 49395bd Compare April 13, 2023 13:16

wenyingd requested a review from jianjuns April 14, 2023 03:18

wenyingd previously approved these changes Apr 14, 2023

View reviewed changes

luolanzone reviewed Apr 14, 2023

View reviewed changes

jianjuns reviewed Apr 14, 2023

View reviewed changes

luolanzone added the action/backport Indicates a PR that requires backports. label Apr 17, 2023

ceclinux dismissed wenyingd’s stale review via f01566a April 17, 2023 06:29

ceclinux force-pushed the document-igmp_max_memberships-for-multicast branch from 49395bd to f01566a Compare April 17, 2023 06:29

Supplyment multicast document with a limitation

9b825b5

Document the limitation of a large number of receiver groups in one node for multicast. Signed-off-by: ceclinux <src655@gmail.com>

ceclinux force-pushed the document-igmp_max_memberships-for-multicast branch from f01566a to 9b825b5 Compare April 17, 2023 12:55

wenyingd approved these changes Apr 18, 2023

View reviewed changes

luolanzone approved these changes Apr 18, 2023

View reviewed changes

ceclinux requested a review from tnqn April 18, 2023 14:04

jianjuns merged commit 6420e67 into antrea-io:main Apr 18, 2023

This was referenced Apr 19, 2023

Automated cherry pick of #4850: Supplyment multicast document with a limitation #4877

Merged

Automated cherry pick of #4850: Supplyment multicast document with a limitation #4890

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supplyment multicast document with a limitation #4850

Supplyment multicast document with a limitation #4850

ceclinux commented Apr 12, 2023

wenyingd Apr 13, 2023

ceclinux Apr 13, 2023

wenyingd Apr 13, 2023

ceclinux Apr 13, 2023

wenyingd Apr 13, 2023

ceclinux Apr 13, 2023

wenyingd left a comment

luolanzone Apr 14, 2023

ceclinux Apr 17, 2023

luolanzone Apr 14, 2023

ceclinux Apr 14, 2023

jianjuns Apr 14, 2023

luolanzone Apr 17, 2023

ceclinux Apr 17, 2023

luolanzone Apr 14, 2023

jianjuns Apr 14, 2023

jianjuns Apr 14, 2023

ceclinux Apr 17, 2023

jianjuns Apr 14, 2023

ceclinux Apr 17, 2023

jianjuns Apr 14, 2023

jianjuns Apr 14, 2023

jianjuns Apr 14, 2023

wenyingd commented Apr 18, 2023

wenyingd left a comment

	Users should change this number according to their needs, and Antrea is not
	Users are responsible to change the value if more than 20 multicast groups are expected per Node.

	### Large number of receiver groups for one node
	### Large number of receiver groups for one Node

		A Linux host limits the maximum number of multicast groups it can subscribe to
		by the default number of 20 [/proc/sys/net/ipv4/igmp_max_memberships](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/).

	Users are responsible for changing the value if Pods on this Node are expected to
	Users are responsible to change the value if Pods on the Node are expected to

Supplyment multicast document with a limitation #4850

Supplyment multicast document with a limitation #4850

Conversation

ceclinux commented Apr 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wenyingd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wenyingd commented Apr 18, 2023

wenyingd left a comment

Choose a reason for hiding this comment