Add support for ExternalIP in AntreaProxy #4866

hongliangl · 2023-04-16T04:04:57Z

This PR adds the ability to serve ExternalIP for AntreaProxy, allowing for
external client accesses to Services running in Kubernetes. In Kubernetes, an
ExternalIP is a feature that allows a Service to be accessed from outside the
cluster using a static IP address.

Signed-off-by: Hongliang Liu lhongliang@vmware.com

tnqn

I guess there may be a misunderstanding between the ExternalIPs field and the ExternalIP type.

pkg/agent/config/service_config.go

pkg/agent/route/route_linux.go

pkg/agent/route/interfaces.go

luolanzone · 2023-05-09T06:37:25Z

@hongliangl could you check and improve the unit test code coverage for this patch? thanks.

hongliangl · 2023-05-09T06:57:15Z

@hongliangl could you check and improve the unit test code coverage for this patch? thanks.

Sure

luolanzone · 2023-05-09T08:19:41Z

@hongliangl please help to update the PR summary and commit messages with the necessary information about ExternalIP to help other reviewers to understand this change.

pkg/agent/openflow/pipeline.go

pkg/agent/openflow/fields.go

pkg/agent/route/route_linux.go

pkg/agent/openflow/client.go

pkg/agent/openflow/client_test.go

pkg/ovs/openflow/testing/utils.go

pkg/agent/proxy/proxier.go

hongliangl · 2023-05-09T11:37:55Z

@hongliangl please help to update the PR summary and commit messages with the necessary information about ExternalIP to help other reviewers to understand this change.

Done

pkg/agent/proxy/proxier.go

pkg/agent/openflow/pipeline.go

pkg/agent/openflow/fields.go

pkg/agent/openflow/pipeline.go

tnqn

LGTM overall

pkg/agent/openflow/fields.go

pkg/agent/route/route_linux.go

tnqn · 2023-05-11T02:48:27Z

pkg/agent/openflow/client.go

+	// installs the flow which has a learn action to maintain the LB decision. The group with the groupID must be
+	// installed before, otherwise the installation will fail.
+	// externalAddress indicates that whether the Service is externally accessible, like NodePort, LoadBalancer and ExternalIP.
+	// nested indicates that whether the Service are backed by Endpoints of other Services.


It sounds the Service and other Services are sharing Endpoints, but we actually mean the Service's Endpoint is other Service's ClusterIPs, right?
Nested Service's ClusterIP -> Nested Service's Endpoint (Other Service's ClusterIP) -> Other Service's Endpoint

How about "nested indiciates the whether the Service are backed by Service IPs of other Services"? @jianjuns @hongliangl

I think it is more readable by be backed by Service IPs of other Services.

tnqn · 2023-05-11T02:50:51Z

pkg/ovs/openflow/testing/utils.go

+			isLoad := spec.Header.Dst == true
+			isMatch := spec.Header.Dst == false


I actually don't understand the change, is it fixing an issue?

This is used to fix the action learn. Previously, action learn to string was wrong.

tnqn

LGTM, let's see if @jianjuns @wenyingd have other comments

wenyingd

LGTM

pkg/agent/openflow/client.go

This PR adds the ability to serve ExternalIP for AntreaProxy, allowing for external client accesses to Services running in Kubernetes. In Kubernetes, an ExternalIP is a feature that allows a Service to be accessed from outside the cluster using a static IP address. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>

tnqn · 2023-05-15T06:17:56Z

/test-all
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all

hongliangl · 2023-05-15T13:59:08Z

/test-windows-proxyall-e2e
/test-windows-e2e

hongliangl · 2023-05-16T00:46:24Z

/test-windows-proxyall-e2e

tnqn · 2023-05-16T02:32:03Z

@jianjuns do you have any other comments on this one?

jianjuns · 2023-05-16T04:04:25Z

@jianjuns do you have any other comments on this one?

No. Please merge.

tnqn · 2023-05-16T05:48:38Z

/skip-conformance which failed on unrelated failure: a deleted service IP happened to be an available external server.

This PR adds the ability to serve ExternalIP for AntreaProxy, allowing for external client accesses to Services running in Kubernetes. In Kubernetes, an ExternalIP is a feature that allows a Service to be accessed from outside the cluster using a static IP address. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>

hongliangl added this to the Antrea v1.12 release milestone Apr 16, 2023

hongliangl added area/proxy Issues or PRs related to proxy functions in Antrea action/release-note Indicates a PR that should be included in release notes. labels Apr 16, 2023

hongliangl force-pushed the 20230414-externalip branch from 5067184 to 18bc9a6 Compare April 20, 2023 13:52

hongliangl requested a review from tnqn April 20, 2023 13:52

hongliangl force-pushed the 20230414-externalip branch from 18bc9a6 to 47c800a Compare April 20, 2023 13:54

tnqn reviewed Apr 27, 2023

View reviewed changes

pkg/agent/config/service_config.go Outdated Show resolved Hide resolved

hongliangl force-pushed the 20230414-externalip branch 2 times, most recently from f2f668b to 30680da Compare May 3, 2023 13:00

jianjuns reviewed May 5, 2023

View reviewed changes

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

hongliangl force-pushed the 20230414-externalip branch from 30680da to cd5be1f Compare May 5, 2023 10:06

jianjuns reviewed May 5, 2023

View reviewed changes

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

hongliangl requested a review from jianjuns May 6, 2023 02:08

tnqn mentioned this pull request May 9, 2023

Optimize ofClient method InstallServiceFlows #4926

Closed

tnqn reviewed May 9, 2023

View reviewed changes

pkg/agent/route/interfaces.go Outdated Show resolved Hide resolved

pkg/agent/route/interfaces.go Outdated Show resolved Hide resolved

hongliangl force-pushed the 20230414-externalip branch 2 times, most recently from 1e69e33 to 2d2d6b7 Compare May 9, 2023 05:33

hongliangl requested a review from tnqn May 9, 2023 06:57

tnqn reviewed May 9, 2023

View reviewed changes

pkg/agent/openflow/pipeline.go Outdated Show resolved Hide resolved

pkg/agent/openflow/pipeline.go Outdated Show resolved Hide resolved

pkg/agent/openflow/fields.go Outdated Show resolved Hide resolved

tnqn reviewed May 9, 2023

View reviewed changes

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

wenyingd reviewed May 9, 2023

View reviewed changes

pkg/agent/openflow/client.go Outdated Show resolved Hide resolved

pkg/agent/openflow/client_test.go Show resolved Hide resolved

pkg/ovs/openflow/testing/utils.go Outdated Show resolved Hide resolved

pkg/agent/proxy/proxier.go Outdated Show resolved Hide resolved

hongliangl force-pushed the 20230414-externalip branch 4 times, most recently from 07a0467 to 0c42fdb Compare May 9, 2023 11:22

tnqn reviewed May 9, 2023

View reviewed changes

tnqn reviewed May 10, 2023

View reviewed changes

pkg/agent/openflow/fields.go Outdated Show resolved Hide resolved

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved

hongliangl force-pushed the 20230414-externalip branch from 4473755 to 897eaee Compare May 10, 2023 23:55

hongliangl requested a review from tnqn May 10, 2023 23:56

hongliangl force-pushed the 20230414-externalip branch 2 times, most recently from bd3c699 to e21422c Compare May 11, 2023 02:38

tnqn reviewed May 11, 2023

View reviewed changes

hongliangl force-pushed the 20230414-externalip branch 2 times, most recently from 78c35eb to b262e13 Compare May 11, 2023 03:03

hongliangl requested a review from tnqn May 11, 2023 07:03

tnqn reviewed May 11, 2023

View reviewed changes

hongliangl force-pushed the 20230414-externalip branch 2 times, most recently from cffffcc to c9eb9e2 Compare May 11, 2023 07:38

wenyingd previously approved these changes May 11, 2023

View reviewed changes

hongliangl requested a review from tnqn May 11, 2023 08:22

tnqn previously approved these changes May 11, 2023

View reviewed changes

jianjuns reviewed May 12, 2023

View reviewed changes

pkg/agent/openflow/client.go Outdated Show resolved Hide resolved

hongliangl dismissed stale reviews from tnqn and wenyingd via 993d472 May 15, 2023 06:13

hongliangl force-pushed the 20230414-externalip branch from c9eb9e2 to 993d472 Compare May 15, 2023 06:13

tnqn approved these changes May 15, 2023

View reviewed changes

tnqn merged commit 8dbb48c into antrea-io:main May 16, 2023

hongliangl deleted the 20230414-externalip branch May 16, 2023 05:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ExternalIP in AntreaProxy #4866

Add support for ExternalIP in AntreaProxy #4866

hongliangl commented Apr 16, 2023 •

edited

Loading

tnqn left a comment

luolanzone commented May 9, 2023

hongliangl commented May 9, 2023

luolanzone commented May 9, 2023

hongliangl commented May 9, 2023

tnqn left a comment

tnqn May 11, 2023

hongliangl May 11, 2023 •

edited

Loading

tnqn May 11, 2023

hongliangl May 11, 2023

tnqn left a comment

wenyingd left a comment

tnqn commented May 15, 2023

hongliangl commented May 15, 2023

hongliangl commented May 16, 2023

tnqn commented May 16, 2023

jianjuns commented May 16, 2023

tnqn commented May 16, 2023

		isLoad := spec.Header.Dst == true
		isMatch := spec.Header.Dst == false

Add support for ExternalIP in AntreaProxy #4866

Add support for ExternalIP in AntreaProxy #4866

Conversation

hongliangl commented Apr 16, 2023 • edited Loading

tnqn left a comment

Choose a reason for hiding this comment

luolanzone commented May 9, 2023

hongliangl commented May 9, 2023

luolanzone commented May 9, 2023

hongliangl commented May 9, 2023

tnqn left a comment

Choose a reason for hiding this comment

tnqn May 11, 2023

Choose a reason for hiding this comment

hongliangl May 11, 2023 • edited Loading

Choose a reason for hiding this comment

tnqn May 11, 2023

Choose a reason for hiding this comment

hongliangl May 11, 2023

Choose a reason for hiding this comment

tnqn left a comment

Choose a reason for hiding this comment

wenyingd left a comment

Choose a reason for hiding this comment

tnqn commented May 15, 2023

hongliangl commented May 15, 2023

hongliangl commented May 16, 2023

tnqn commented May 16, 2023

jianjuns commented May 16, 2023

tnqn commented May 16, 2023

hongliangl commented Apr 16, 2023 •

edited

Loading

hongliangl May 11, 2023 •

edited

Loading