-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Multi-cluster user guide #4889
Conversation
docs/multicluster/user-guide.md
Outdated
|
||
| Pod-to-Pod connectivity provided by underlay | Gateway Enabled | MC EndpointTypes | Cross-cluster Service/Pod communications | | ||
| -------------------------------------------- | --------------- | ----------------- | ---------------------------------------- | | ||
| No | No | ClusterIP(default)| No | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the MC EndpointTypes
for this one. I thought MC Services would not work in this case (no cross-cluster Service traffic).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it won't work, changed it to None
.
I was thinking there is no 'None' type of EndpointTypes before.
a43e392
to
042db0e
Compare
docs/multicluster/user-guide.md
Outdated
@@ -81,6 +81,12 @@ antrea-agent.conf: | | |||
namespace: "" # Change to the Namespace where antrea-mc-controller is deployed. | |||
``` | |||
|
|||
In order for Multi-cluster features to work, `enableGateway` should be set to true by the user, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading this again, and I think a small improvment could be:
In order for Multi-cluster features to work, it is necessary for
enableGateway
to be set to true by the user,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
docs/multicluster/user-guide.md
Outdated
|
||
| Pod-to-Pod connectivity provided by underlay | Gateway Enabled | MC EndpointTypes | Cross-cluster Service/Pod communications | | ||
| -------------------------------------------- | --------------- | ----------------- | ---------------------------------------- | | ||
| No | No | None | No | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think it is better, you can replace "None" with "N/A"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks.
Update Multi-cluster user guide to provide more details for Gateway enablement. Signed-off-by: Lan Luo <luola@vmware.com>
042db0e
to
fc44d71
Compare
/skip-all |
Update Multi-cluster user guide to provide more details for Gateway enablement. Signed-off-by: Lan Luo <luola@vmware.com>
Update Multi-cluster user guide to provide more details for Gateway enablement. Signed-off-by: Lan Luo <luola@vmware.com>
Update Multi-cluster user guide to provide more details for Gateway enablement.