Add OVS table name as label for ovs_flow_count Prometheus metrics #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr7258
force-pushed
the
add_prometheus_label
branch
from
13ff036
to
0ad9e37
Compare
|
@cr7258 Thanks for your contribution. |
antoninbas
reviewed
Apr 24, 2023
There was a problem hiding this comment.
minor comment, otherwise LGTM
IMO, this is a safe change because:
- I consider it to be backward-compatible. Previous user queries should not be impacted.
- This should not increase the cardinality of the metric, as the 2 labels (table_id and table_name) are essentially synonyms (for each table_id, we have one and only one table_name).
pkg/agent/metrics/prometheus.go
Outdated
| @@ -79,9 +79,9 @@ var ( | |||
| Namespace: metricNamespaceAntrea, | |||
| Subsystem: metricSubsystemAgent, | |||
| Name: "ovs_flow_count", | |||
| Help: "Flow count for each OVS flow table. The TableID is used as a label.", | |||
| Help: "Flow count for each OVS flow table. The TableID and TableName are used as a label.", | |||
There was a problem hiding this comment.
s/are used as a label./are used as labels.
added 3 commits
April 25, 2023 09:30
Signed-off-by: Cheng, Seven <seven.cheng@sap.com>
Signed-off-by: Cheng, Seven <seven.cheng@sap.com>
Signed-off-by: Cheng, Seven <seven.cheng@sap.com>
cr7258
force-pushed
the
add_prometheus_label
branch
from
0fa98ae
to
2cd9507
Compare
antoninbas
approved these changes
Apr 25, 2023
|
/test-all |
tnqn
added
the
action/release-note
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
…trea-io#4893) Signed-off-by: Cheng, Seven <seven.cheng@sap.com> Co-authored-by: Cheng, Seven <seven.cheng@sap.com>
ceclinux
pushed a commit
to ceclinux/antrea
that referenced
this pull request
Jun 5, 2023
…trea-io#4893) Signed-off-by: Cheng, Seven <seven.cheng@sap.com> Co-authored-by: Cheng, Seven <seven.cheng@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4566
Add the OVS table name as a label for the
antrea_agent_ovs_flow_countmetric to facilitate identifying the corresponding table for each metric.