Add appliedTo Pod namespace / name to audit logs #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That PR has been merged |
antoninbas
force-pushed
the
add-applied-to-pod-name-to-audit-logs
branch
from
7841ccf
to
ff1c882
Compare
antoninbas
added
area/monitoring/auditing
antoninbas
force-pushed
the
add-applied-to-pod-name-to-audit-logs
branch
from
ff1c882
to
00aa223
Compare
antoninbas
force-pushed
the
add-applied-to-pod-name-to-audit-logs
branch
from
00aa223
to
97559a8
Compare
|
/test-all |
We include 2 new fields in the audit logs: * the "direction" of the NP rule (`Ingress` or `Egress`) * the reference of the Pod to which the NP rule is applied (as `<namespace>/<name>`). These new fields are *NOT* added to the end of the logs, which could break existing consumers. We also refactor the e2e tests for AuditLogging to improve correctness and readbility. Some logs were not validated properly because of an early "break" statement, and some log fields (e.g., logLabel) were not validated. Fixes antrea-io#3794 Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
add-applied-to-pod-name-to-audit-logs
branch
from
97559a8
to
9569680
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We include 2 new fields in the audit logs:
IngressorEgress)<namespace>/<name>).These new fields are NOT added to the end of the logs, which could
break existing consumers.
We also refactor the e2e tests for AuditLogging to improve correctness
and readbility. Some logs were not validated properly because of an
early "break" statement, and some log fields (e.g., logLabel) were not
validated.
Fixes #3794