Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows OVS version to 3.0.5 #5120

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

wenyingd
Copy link
Contributor

No description provided.

Signed-off-by: wenyingd <wenyingd@vmware.com>
@wenyingd wenyingd requested a review from XinShuYang June 13, 2023 03:46
@luolanzone luolanzone added the area/OS/windows Issues or PRs related to the Windows operating system. label Jun 13, 2023
@wenyingd
Copy link
Contributor Author

/test-windows-all

@wenyingd wenyingd requested a review from tnqn June 15, 2023 23:30
@wenyingd
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@wenyingd
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

1 similar comment
@wenyingd
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@wenyingd
Copy link
Contributor Author

@tnqn @antoninbas could you help review this one? Tests in antrea CI using OVS 3.0.5 have passed.

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, defer to @antoninbas to see if he knows anything we need to notice for OVS 3.0.

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. However I have 2 questions:

  1. Can we also upgrade to OVS 3.x for antrea-ubuntu?
  2. It seems that (based on the OVS changelog), we may now be able to support IPv6 for Windows Nodes. I am not saying this is a priority, but maybe we could open an issue to track this?

@antoninbas
Copy link
Contributor

Regarding my comment above:

It seems that (based on the OVS changelog), we may now be able to support IPv6 for Windows Nodes. I am not saying this is a priority, but maybe we could open an issue to track this?

An issue would definitely be beneficial IMO, as it is not obvious from our documentation that we don't support IPv6 for Windows Nodes (unless I am missing something). We only have a runtime error. If we have an issue, it increases the chances of someone finding some relevant information if they search for it.

@wenyingd
Copy link
Contributor Author

Regarding my comment above:

It seems that (based on the OVS changelog), we may now be able to support IPv6 for Windows Nodes. I am not saying this is a priority, but maybe we could open an issue to track this?

An issue would definitely be beneficial IMO, as it is not obvious from our documentation that we don't support IPv6 for Windows Nodes (unless I am missing something). We only have a runtime error. If we have an issue, it increases the chances of someone finding some relevant information if they search for it.

I used to try to enable IPv6 on Windows Nodes, but I found that Windows HNSNetwork has many limitations on IPv6, the "transparent" type ( we used in antrea) didn't support IPv6 when I performed the experiments. I could open an issue to track it.

As for Linux, I am OK to bump OVS to 3.X. The motivation to upgrade Windows OVS to 3.X is because we use the signed OVS driver in Antrea commercial version, and the next usable signed driver is based on OVS 3.X not 2.17.X. But for Linux, opensource OVS is used even in the commercial Antrea, so we do not have this limitation or urgent requirement.

@antoninbas
Copy link
Contributor

As for Linux, I am OK to bump OVS to 3.X. The motivation to upgrade Windows OVS to 3.X is because we use the signed OVS driver in Antrea commercial version, and the next usable signed driver is based on OVS 3.X not 2.17.X. But for Linux, opensource OVS is used even in the commercial Antrea, so we do not have this limitation or urgent requirement.

I understand the motivation for this PR, but we try to do what's best for Antrea as an OSS project, and it seems best to keep the 2 platforms in sync here.
I didn't ask for the Linux version to be upgraded in the same PR.

@wenyingd
Copy link
Contributor Author

This issue (#5162) is created to track IPv6 on Windows

@antoninbas antoninbas merged commit 65020aa into antrea-io:main Jun 21, 2023
@wenyingd wenyingd deleted the ovs_3.0.5 branch April 3, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/OS/windows Issues or PRs related to the Windows operating system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants