Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build different images for antrea-agent and antrea-controller #5902

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

jainpulkit22
Copy link
Contributor

@jainpulkit22 jainpulkit22 commented Jan 23, 2024

Part of #5691.

Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, two nits.

build/images/Dockerfile.agent.build.coverage Outdated Show resolved Hide resolved
build/images/Dockerfile.controller.build.coverage Outdated Show resolved Hide resolved
@luolanzone
Copy link
Contributor

The PR can't resolve the issue 5691, you may update it as Part of #5691

Signed-off-by: Pulkit Jain <jainpu@vmware.com>
Co-authored-by: Pulkit Jain <jainpu@vmware.com>

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

@jainpulkit22 I added a commit to your PR for the sake of moving forward. In order to update the build infra, I needed some of the workflow changes to enable pushing the new images to the docker registry.

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas antoninbas merged commit 18dc013 into antrea-io:main Jan 23, 2024
50 of 54 checks passed
@jainpulkit22 jainpulkit22 added this to the Antrea v1.15 release milestone Jan 24, 2024
@jainpulkit22 jainpulkit22 added the action/release-note Indicates a PR that should be included in release notes. label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants