Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Multiple Kind CI Jobs on a single testbed #6010

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jainpulkit22
Copy link
Contributor

@jainpulkit22 jainpulkit22 commented Feb 21, 2024

Run Multiple kind Jobs on same testbed.
Fixes #5734

@rajnkamr rajnkamr added this to the Antrea v2.0 release milestone Feb 21, 2024
@rajnkamr rajnkamr added area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers kind/design Categorizes issue or PR as related to design. area/test/jenkins Issue about jenkins setup code labels Feb 22, 2024
@jainpulkit22 jainpulkit22 force-pushed the multiple-kind-jobs branch 2 times, most recently from 5b66784 to 5672557 Compare March 6, 2024 10:21
@rajnkamr
Copy link
Contributor

1.Estimated size required for a single job run is ~4gb, after each job run success/failure, custom image must be cleaned to allow other jobs to start. ( It is standard practice )
2.If space is not available, kind jobs will be queued. Need to get more data by running multiple kind job preferably before merge.
3.With the change we can maintain fewer kind test beds and get to know min/max no of kind test beds required to be maintained.

@jainpulkit22
Copy link
Contributor Author

1.Estimated size required for a single job run is ~4gb, after each job run success/failure, custom image must be cleaned to allow other jobs to start. ( It is standard practice ) 2.If space is not available, kind jobs will be queued. Need to get more data by running multiple kind job preferably before merge. 3.With the change we can maintain fewer kind test beds and get to know min/max no of kind test beds required to be maintained.

We can't say that the estimated size for the job is 4gb, it is actually double the size, because we will have multiple images getting downloaded for test, then we will have kubernetes cluster, and different containers running as well. When I mentioned size 4GB, it was the size that was occupied on my local docker desktop, by the antrea images.

@rajnkamr
Copy link
Contributor

1.Estimated size required for a single job run is ~4gb, after each job run success/failure, custom image must be cleaned to allow other jobs to start. ( It is standard practice ) 2.If space is not available, kind jobs will be queued. Need to get more data by running multiple kind job preferably before merge. 3.With the change we can maintain fewer kind test beds and get to know min/max no of kind test beds required to be maintained.

We can't say that the estimated size for the job is 4gb, it is actually double the size, because we will have multiple images getting downloaded for test, then we will have kubernetes cluster, and different containers running as well. When I mentioned size 4GB, it was the size that was occupied on my local docker desktop, by the antrea images.

For 2 & 3, need to have actual space identified for a single job to decide on no of kind test beds.

@jainpulkit22
Copy link
Contributor Author

1.Estimated size required for a single job run is ~4gb, after each job run success/failure, custom image must be cleaned to allow other jobs to start. ( It is standard practice ) 2.If space is not available, kind jobs will be queued. Need to get more data by running multiple kind job preferably before merge. 3.With the change we can maintain fewer kind test beds and get to know min/max no of kind test beds required to be maintained.

We can't say that the estimated size for the job is 4gb, it is actually double the size, because we will have multiple images getting downloaded for test, then we will have kubernetes cluster, and different containers running as well. When I mentioned size 4GB, it was the size that was occupied on my local docker desktop, by the antrea images.

For 2 & 3, need to have actual space identified for a single job to decide on no of kind test beds.

but if we will have more testbed, then what will be the purpose of multiple kind jobs on single testbed, we can either leverage one testbed with more resources.

@rajnkamr
Copy link
Contributor

1.Estimated size required for a single job run is ~4gb, after each job run success/failure, custom image must be cleaned to allow other jobs to start. ( It is standard practice ) 2.If space is not available, kind jobs will be queued. Need to get more data by running multiple kind job preferably before merge. 3.With the change we can maintain fewer kind test beds and get to know min/max no of kind test beds required to be maintained.

We can't say that the estimated size for the job is 4gb, it is actually double the size, because we will have multiple images getting downloaded for test, then we will have kubernetes cluster, and different containers running as well. When I mentioned size 4GB, it was the size that was occupied on my local docker desktop, by the antrea images.

For 2 & 3, need to have actual space identified for a single job to decide on no of kind test beds.

but if we will have more testbed, then what will be the purpose of multiple kind jobs on single testbed, we can either leverage one testbed with more resources.

It will depend on max allowed space we can reserve for a kind vm, even if run ci jobs in parallel , we might not be allowed to reserve a powerful vm which can run all ci jobs in parallel , however benefit is that we would reduce no of vms needed for running kind ci tests.

@jainpulkit22 jainpulkit22 marked this pull request as ready for review March 13, 2024 04:52
@jainpulkit22 jainpulkit22 changed the title [WIP] Run Multiple kind Jobs(CI) on same testbed Run Multiple kind Jobs(CI) on same testbed Mar 13, 2024
ci/jenkins/test.sh Outdated Show resolved Hide resolved
@rajnkamr rajnkamr changed the title Run Multiple kind Jobs(CI) on same testbed Run Multiple kind Jobs on a single testbed Apr 23, 2024
@rajnkamr rajnkamr changed the title Run Multiple kind Jobs on a single testbed Run Multiple Kind Jobs on a single testbed Apr 23, 2024
@rajnkamr rajnkamr changed the title Run Multiple Kind Jobs on a single testbed Run Multiple Kind CI Jobs on a single testbed Apr 23, 2024
@XinShuYang
Copy link
Contributor

LGTM, I will wait for @KMAnju-2021 's confirmation regarding the jenkins kind verification before approving. Please ensure that all related Jenkins jobs can pass.

@jainpulkit22 jainpulkit22 force-pushed the multiple-kind-jobs branch 2 times, most recently from 80581a5 to e077b17 Compare May 22, 2024 07:15
@jainpulkit22 jainpulkit22 requested review from antoninbas and removed request for antoninbas May 23, 2024 05:56
@rajnkamr
Copy link
Contributor

/test-rancher-networkpolicy

@rajnkamr
Copy link
Contributor

/test-rancher-conformance

@jainpulkit22 jainpulkit22 requested review from antoninbas and removed request for antoninbas June 5, 2024 08:33
Makefile Outdated Show resolved Hide resolved
hack/build-antrea-linux-all.sh Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Pulkit Jain <pulkit.jain@broadcom.com>
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@XinShuYang can you take one last look please

Copy link
Contributor

@XinShuYang XinShuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for kind CI changes, @KMAnju-2021 do you have more comments?

@KMAnju-2021
Copy link
Contributor

LGTM, for kind CI changes, @KMAnju-2021 do you have more comments?

Hi @XinShuYang, I don't have any comments, thanks !

@XinShuYang
Copy link
Contributor

/test-kind-conformance
/test-kind-networkpolicy
/test-kind-e2e

@antoninbas
Copy link
Contributor

I don't see any status for test-kind-networkpolicy and test-kind-e2e. Is there an issue?

@jainpulkit22
Copy link
Contributor Author

I don't see any status for test-kind-networkpolicy and test-kind-e2e. Is there an issue?

@KMAnju-2021 can you check the trigger comments.

@jainpulkit22
Copy link
Contributor Author

/test-kind-networkpolicy

@KMAnju-2021
Copy link
Contributor

KMAnju-2021 commented Jun 13, 2024

I don't see any status for test-kind-networkpolicy and test-kind-e2e. Is there an issue?

Hi @antoninbas, fixed test-kind-networkpolicy , and test-kind-e2e trigger phrase is not valid, thanks!

@antoninbas antoninbas merged commit f7de360 into antrea-io:main Jun 13, 2024
51 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers area/test/jenkins Issue about jenkins setup code kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run multiple Kind Jobs on a single VM
7 participants