Skip IPSec/WireGuard e2e test when the Multicast feature is enabled #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wenyingd
reviewed
Apr 26, 2024
| @@ -42,6 +42,7 @@ func TestIPSec(t *testing.T) { | |||
| t.Fatalf("Error when setting up test: %v", err) | |||
| } | |||
| defer teardownTest(t, data) | |||
| skipIfMulticastEnabled(t, data) | |||
There was a problem hiding this comment.
Regarding the IPSec test part, do you mean to do config mutation as wireguard test?
There was a problem hiding this comment.
No, my thought is to keep the two consistent, either both skip the case that "multicast.enabled=false", or use mutate to enforce they are run.
This is an e2e fix because of PR antrea-io#5920. Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
skip-encryption-e2e-when-multicast-enabled
branch
from
bac8086
to
1563807
Compare
luolanzone
commented
Apr 28, 2024
| skipIfEncapModeIsNot(t, data, config.TrafficEncapModeEncap) | ||
| for _, node := range clusterInfo.nodes { | ||
| skipIfMissingKernelModule(t, data, node.name, []string{"wireguard"}) | ||
| } | ||
| var previousTrafficEncryptionMode string | ||
| var previousMulticastEnabledState bool |
There was a problem hiding this comment.
After sync with wenying, we keep both IPSec and WireGuard test in the same way to simply disabled related encryption e2e tests when multicast is enabled. So no need to do this kind of check and restore anymore.
|
/test-e2e |
luolanzone
added a commit
to luolanzone/antrea
that referenced
this pull request
Jun 17, 2024
…ntrea-io#6264) This is an e2e fix because of PR antrea-io#5920. Signed-off-by: Lan Luo <luola@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Jun 17, 2024
luolanzone
added a commit
to luolanzone/antrea
that referenced
this pull request
Jun 20, 2024
…ntrea-io#6264) This is an e2e fix because of PR antrea-io#5920. Signed-off-by: Lan Luo <luola@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an e2e fix because of PR #5920.