Fix antctl mc deploy command usage

[roopeshsn]

This patch ensures that v is optional in the version tag and improves the error message if the specified version tag is not found.

If someone provide an invalid tag the error message would be,

$ ./bin/antctl mc  deploy leadercluster -n antrea-multicluster --antrea-version 2.15.0
Error: specified version tag is not found

This PR addresses the issue #6151

[roopeshsn]

Thanks, @luolanzone and @tnqn for the review! After the review changes the new test cases for this patch are failing because the check is present in the deploy function. Can I move the check,

if version != "latest" && !strings.HasPrefix(version, "v") {
    version = fmt.Sprintf("v%s", version)
} 

inside generateManifests?

[tnqn]

After the review changes the new test cases for this patch are failing because the check is present in the deploy function. Can I move the check inside generateManifests?

Yes, actually it's better to move the check there to deal with "version" in a single place. But I don't think it's caused by the review changes, the test failed before the review changes are applied.

[luolanzone]

Hi @roopeshsn Could you check the failure of golanglint result here
It shows pkg/antctl/raw/multicluster/deploy/deploy_helper.go:59: File is not gofmt-ed with -s(gofmt), please do the format and update the PR. Thanks.

[roopeshsn]

Hi @roopeshsn Could you check the failure of golanglint result here It shows pkg/antctl/raw/multicluster/deploy/deploy_helper.go:59: File is not gofmt-ed with -s(gofmt), please do the format and update the PR. Thanks.

Updated the PR with formatting.

[tnqn]

LGTM

[tnqn]

/skip-all
/test-multicluster-e2e