Update documents to replace AntreaProxy with Antrea Proxy #6515
Conversation
hongliangl
changed the title
hongliangl
force-pushed
the
20240708-rename-antreaproxy
branch
from
6c0ecc3
to
e8c40a6
Compare
hongliangl
force-pushed
the
20240708-rename-antreaproxy
branch
from
e8c40a6
to
b211195
Compare
| type, `noEncap`, `noSNAT` traffic mode, and `AntreaProxy` feature enabled. Configuration | ||
| with `ProxyAll` feature enabled is not verified. | ||
| type, `noEncap`, `noSNAT` traffic mode, and Antrea Proxy enabled. Configuration | ||
| with `proxyAll` enabled is not verified. |
There was a problem hiding this comment.
Worthy to check all ProxyAll and update ProxyAll to proxyAll if necessary.
I can see there are inconsistent in some docs.
There was a problem hiding this comment.
I found that every ProxyAll (Without quotting) is at the beginning of sentences. I don't think we need to update them.
There was a problem hiding this comment.
Only when it refers to the proxyAll field in the YAML, we should we use proxyAll.
There was a problem hiding this comment.
Only when it refers to the proxyAll field in the YAML, we should we use proxyAll.
I may not get what you mean. Do you mean that we should use proxyAll in the YAML comments, even if the word is at the beginning of sentences?
There was a problem hiding this comment.
'proxyAllhere should refer to theproxyAllfield inantrea-agent.confright? In this case, we should useproxyAllas Lan suggested, notProxyAll, as the field is named proxyAll`. It does not matter whether it begins a sentence or not.
There was a problem hiding this comment.
Thanks, got that. If so, how about this: Option proxyAll?
There was a problem hiding this comment.
I think the current version here "Configuration
with proxyAll enabled is not verified" is fine.
There was a problem hiding this comment.
Thanks, got that. If so, how about this: Option proxyAll?
I meant that how about changing the ProxyAll tells antrea-agent ..... at the beginning of sentences in YAML files to Option proxyAll tells antrea-agent.
I think the current version here "Configuration
with proxyAll enabled is not verified" is fine.
I didn't change this one where proxyAll is not at the beginning of sentences. @jianjuns
There was a problem hiding this comment.
OK. I think we can say "proxyAll tells..."
hongliangl
force-pushed
the
20240708-rename-antreaproxy
branch
from
b211195
to
5cabe64
Compare
hongliangl
force-pushed
the
20240708-rename-antreaproxy
branch
from
5cabe64
to
e5c4fc6
Compare
hongliangl
force-pushed
the
20240708-rename-antreaproxy
branch
from
e5c4fc6
to
51ed9da
Compare
Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
force-pushed
the
20240708-rename-antreaproxy
branch
from
51ed9da
to
b1bc4a8
Compare
|
@jianjuns Could you help do the final confirm to see if we can merge this? Thanks |
I do not have further comments, but should we wait for your other Antrea Proxy fix PR merged first, and so we can update new added "AntreaProxy" in that PR too? |
@jianjuns IIRC, I don't have other Antrea Proxy PRs right now. If you meant it is #6308, I have rebased this PR. |
|
/skip-all |
…6515) Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
No description provided.