Change antctl make target #6686
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running "make antctl" is common when someone wants to build antctl for the current machine. The current target builds 3 versions of the antctl binary: one for Linux, one for Windows and one for Darwin (using the architecture of the current machine). This seems unnecessary and potentially confusing. We change the antctl target to be an alias of antctl-release. Running "make antctl" will now produce a single binary named "antctl", which can be run on the current machine. For backwards-compatibility, we preserve the ability to run "make antctl-linux", "make antctl-windows", and "make antctl-darwin". These 3 targets combined will produce the 3 antctl binaries described above. Finally, we update the Github workflow in charge of validating the antctl Go build. We now have one dedicated step for each supported OS / arch combination. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added
area/component/antctl
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running "make antctl" is common when someone wants to build antctl for the current machine. The current target builds 3 versions of the antctl binary: one for Linux, one for Windows and one for Darwin (using the architecture of the current machine). This seems unnecessary and potentially confusing. We change the antctl target to be an alias of antctl-release. Running "make antctl" will now produce a single binary named "antctl", which can be run on the current machine.
For backwards-compatibility, we preserve the ability to run "make antctl-linux", "make antctl-windows", and "make antctl-darwin". These 3 targets combined will produce the 3 antctl binaries described above.
Finally, we update the Github workflow in charge of validating the antctl Go build. We now have one dedicated step for each supported OS / arch combination.