-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Support OVS commands in antctl #794
Conversation
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
/test-all |
docs/antctl.md
Outdated
@@ -66,6 +66,12 @@ antctl get controllerinfo | |||
antctl get agentinfo | |||
``` | |||
|
|||
On Windows Nodes, an environment variable `$env:POD_NAME` needs to be set when printing the runtime information of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just for antctl to detect it should run in agent mode? Maybe we should add a cmd line argument for agent or controller mode, and even specify which Node to run agent commands since now agent API supports remote access too. @weiqiangt, @lzhecheng : what you think?
And do you think possible to run antctl in the management Pod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable is to help antctl identify it is running in agent mode.
If we run antctl in the management Pod on Windows, it will be more complicated. For the Antrea Agent process is actually running on the host(the listening Port is on the host), if we run antctl in the Pod, we might need another named pipe to forward the commands to host again to connect to the Agent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment variable is to help antctl identify it is running in agent mode.
If we run antctl in the management Pod on Windows, it will be more complicated. For the Antrea Agent process is actually running on the host(the listening Port is on the host), if we run antctl in the Pod, we might need another named pipe to forward the commands to host again to connect to the Agent.
Can we add a flag to tell antctl it is running in agent mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let us add a flag. Maybe antctl can by default connect to the current Node's IP (or loopback IP on Linux) when the agent mode flag is set.
59a76e4
to
ef02f9f
Compare
/test-all |
/test-all |
Use "cmd.exe" on Windows when executing OVS commands.
Use the named pipe file for ovs-vswitchd control socket in ovs-appctl command.