Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Support OVS commands in antctl #794

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Jun 4, 2020

Use "cmd.exe" on Windows when executing OVS commands.
Use the named pipe file for ovs-vswitchd control socket in ovs-appctl command.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@wenyingd
Copy link
Contributor Author

wenyingd commented Jun 4, 2020

/test-all

docs/antctl.md Outdated
@@ -66,6 +66,12 @@ antctl get controllerinfo
antctl get agentinfo
```

On Windows Nodes, an environment variable `$env:POD_NAME` needs to be set when printing the runtime information of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for antctl to detect it should run in agent mode? Maybe we should add a cmd line argument for agent or controller mode, and even specify which Node to run agent commands since now agent API supports remote access too. @weiqiangt, @lzhecheng : what you think?

And do you think possible to run antctl in the management Pod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable is to help antctl identify it is running in agent mode.

If we run antctl in the management Pod on Windows, it will be more complicated. For the Antrea Agent process is actually running on the host(the listening Port is on the host), if we run antctl in the Pod, we might need another named pipe to forward the commands to host again to connect to the Agent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable is to help antctl identify it is running in agent mode.

If we run antctl in the management Pod on Windows, it will be more complicated. For the Antrea Agent process is actually running on the host(the listening Port is on the host), if we run antctl in the Pod, we might need another named pipe to forward the commands to host again to connect to the Agent.

Can we add a flag to tell antctl it is running in agent mode?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let us add a flag. Maybe antctl can by default connect to the current Node's IP (or loopback IP on Linux) when the agent mode flag is set.

@wenyingd wenyingd force-pushed the windows_antctl branch 2 times, most recently from 59a76e4 to ef02f9f Compare June 5, 2020 04:14
@wenyingd
Copy link
Contributor Author

wenyingd commented Jun 5, 2020

/test-all

pkg/ovs/ovsctl/appctl.go Outdated Show resolved Hide resolved
@wenyingd
Copy link
Contributor Author

wenyingd commented Jun 5, 2020

/test-all

@wenyingd wenyingd merged commit 53ae6a5 into antrea-io:master Jun 8, 2020
@wenyingd wenyingd deleted the windows_antctl branch August 18, 2020 01:43
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants