Improve liveness probe for antrea-ovs container #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
* Increase failureThreshold to 5 and timeout to 10 seconds to avoid frequent restarts when the node is overloaded. * Set timeoutSeconds explicitly otherwise it's defaulted to 1 second, though it's not honored by docker CRI. * Keep the output of probe script so that it will be appended to the message of liveness failure event and be helpful to see the actual problem.
|
@antoninbas thanks for the quick review. /test-all |
|
/test-conformance |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
* Increase failureThreshold to 5 and timeout to 10 seconds to avoid frequent restarts when the node is overloaded. * Set timeoutSeconds explicitly otherwise it's defaulted to 1 second, though it's not honored by docker CRI. * Keep the output of probe script so that it will be appended to the message of liveness failure event and be helpful to see the actual problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase failureThreshold to 5 and timeout to 10 seconds to avoid
frequent restarts when the node is overloaded.
Set timeoutSeconds explicitly otherwise it's defaulted to 1 second,
though it's not honored by docker CRI.
Keep the output of probe script so that it will be appended to the
message of liveness failure event and be helpful to see the actual
problem.
For #833