Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper apostrophe in stats card's header #75

Merged
merged 6 commits into from
Jul 19, 2020

Conversation

sreetamdas
Copy link
Contributor

@sreetamdas sreetamdas commented Jul 16, 2020

this PR focuses on two things:

@sreetamdas
Copy link
Contributor Author

apologies, had to revert the verbose console log message that I'd added; I'll add more test cases for this

@anuraghazra
Copy link
Owner

Hi @sreetamdas thanks for the PR. i was just think that i would probably wont support the GITHUB_TOKEN and only support the PATS since it could be hard to manage later.

And i was think to just update the readme to solve the issue #74

I can still merge these changes though, only the "fix: remove 's' after apostrophe if name ends with 's'"

@anuraghazra anuraghazra added the enhancement New feature or request. label Jul 16, 2020
@sreetamdas
Copy link
Contributor Author

alright, sure!
reverted to resolve only the first one

@anuraghazra
Copy link
Owner

@sreetamdas LGTM, can you add a small test to for this?

@mainrs
Copy link

mainrs commented Jul 18, 2020

Btw, if the username ends in an s, you should still append an ' after it: Thomas' Github stats. The same applies to an x: Felix' GitHub statis afaik.

@anuraghazra
Copy link
Owner

@sirwindfield yup, and i think this would actually do Thomas'

        <text x="25" y="35" class="header">${name}'${ name.slice(-1) === "s" ? "" : "s"} GitHub Stats</text>

But i think the names ends with X has to be considered as @sirwindfield mentioned

@sreetamdas

@anuraghazra anuraghazra changed the base branch from master to add-license-1 July 19, 2020 18:29
@anuraghazra anuraghazra changed the base branch from add-license-1 to master July 19, 2020 18:29
@anuraghazra anuraghazra changed the title Respect GITHUB_TOKEN env var before using PATs, remove 's if name ends with "s" Added proper apostrophe in stats card's header Jul 19, 2020
@anuraghazra anuraghazra merged commit dd2c7ed into anuraghazra:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants