-
-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added proper apostrophe in stats card's header #75
Conversation
apologies, had to revert the verbose console log message that I'd added; I'll add more test cases for this |
Hi @sreetamdas thanks for the PR. i was just think that i would probably wont support the GITHUB_TOKEN and only support the PATS since it could be hard to manage later. And i was think to just update the readme to solve the issue #74 I can still merge these changes though, only the "fix: remove 's' after apostrophe if name ends with 's'" |
This reverts commit 2becbe5.
alright, sure! |
@sreetamdas LGTM, can you add a small test to for this? |
Btw, if the username ends in an |
@sirwindfield yup, and i think this would actually do Thomas' <text x="25" y="35" class="header">${name}'${ name.slice(-1) === "s" ? "" : "s"} GitHub Stats</text> But i think the names ends with X has to be considered as @sirwindfield mentioned |
's
if name ends with "s"
this PR focuses on two things:
s
, no longer add's
at the endGITHUB_TOKEN
from the env variables would no longer be respected, instead attempting to useprocess.env[`PAT_${retries + 1}`]
— fix: increase github rate limit with multiple PATs #58