v1.18: sdk: Rederive Copy on Rent and EpochSchedule #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
approved these changes
Jun 17, 2024
|
Like the approach of not reverting! |
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
sdk: Rederive Clone on Rent and EpochSchedule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The removal of the
Copyderivation onRentandEpochSchedulein solana-labs#32767 is a breaking change, and wasn't signaled to downstream users who were depending on theCopybehavior, such as https://discord.com/channels/428295358100013066/966782389839876096/1250593405118058616Summary of Changes
The breaking change is fine for 2.0, but we should at least re-establish the Copy derivation for 1.18 to avoid unnecessary downstream breakage.
I should have realized this while reviewing the SPL PRs but didn't think it would impact anyone (wrongly).
Note that this PR doesn't revert the previous PR, but simply re-adds the
Copyderivation and adds a few#[allow(...)]s for clippy to pass, so there's no change in behavior.Fixes #