Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: tweak unittest #1460

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Nov 9, 2021

🏠 Internal
tweak unittest to prepare monorepo

  1. import from source code instead lib
  2. fix flaky test
  3. export variable used by Superset

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner November 9, 2021 08:40
@vercel
Copy link

vercel bot commented Nov 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/BUvQ15ZrFNRJ5ZLSWm5LweS9p9ri
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-tweakut-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1460 (051e063) into master (0ca4f73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1460   +/-   ##
=======================================
  Coverage   30.62%   30.62%           
=======================================
  Files         499      499           
  Lines       10048    10048           
  Branches     1699     1699           
=======================================
  Hits         3077     3077           
  Misses       6723     6723           
  Partials      248      248           
Impacted Files Coverage Δ
plugins/plugin-chart-echarts/src/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca4f73...051e063. Read the comment docs.

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 2a7c924 into apache-superset:master Nov 9, 2021
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants