Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-pivot-table): cross filtering by adhoc column #1465

Merged

Conversation

kgabryje
Copy link
Contributor

Cross filtering in PivotTable v2 didn't work properly when applied to an adhoc column (new feature). This PR fixes the issue.

image

@kgabryje kgabryje requested a review from a team as a code owner November 10, 2021 18:23
@vercel
Copy link

vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/7KTQu1miGZGSKt2GM1d86SYHShQy
✅ Preview: https://superset-ui-git-fork-kgabryje-fix-cross-filter-f80043-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1465 (51f170d) into master (9e46f98) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
- Coverage   30.94%   30.92%   -0.03%     
==========================================
  Files         502      502              
  Lines       10212    10219       +7     
  Branches     1760     1762       +2     
==========================================
  Hits         3160     3160              
- Misses       6800     6807       +7     
  Partials      252      252              
Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e46f98...51f170d. Read the comment docs.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants