Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: make all filter operators uppercase #378

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

villebro
Copy link
Contributor

🐛 Bug Fix

Currently unary operators are uppercase, while binary and set operators are lowercase, which looks weird. As of PR 9556 Superset now expects all filter operators to be uppercase (it does work with lowercase, but this support might be removed at some point).

@villebro villebro requested a review from a team as a code owner April 18, 2020 11:08
@vercel
Copy link

vercel bot commented Apr 18, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/superset/superset-ui/ghwmfneot
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-uppercase-operators.superset.now.sh

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   26.35%   26.35%           
=======================================
  Files         192      192           
  Lines        5256     5256           
  Branches      459      459           
=======================================
  Hits         1385     1385           
  Misses       3842     3842           
  Partials       29       29           
Impacted Files Coverage Δ
packages/superset-ui-query/src/types/Operator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9cce3...bfddf06. Read the comment docs.

@kristw kristw merged commit 1f9e493 into apache-superset:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants