Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Eventual Scan test in ComprehensiveIT #4754

Open
wants to merge 8 commits into
base: 3.1
Choose a base branch
from
Open

Added Eventual Scan test in ComprehensiveIT #4754

wants to merge 8 commits into from

Conversation

ArbaazKhan1
Copy link
Contributor

@ArbaazKhan1 ArbaazKhan1 commented Jul 24, 2024 •
edited
Loading

Closes issue #4705
Added in a new test into ComprehensiveIT, that check the behavior of eventual scan. Structure of the test is as follows:

  • Add data to table
  • Run eventual scan
  • Add new data to table
  • Run 2nd eventual scan
  • Should not see new data

@ctubbsii ctubbsii added this to the 3.1.0 milestone Jul 24, 2024
@dlmarion dlmarion changed the base branch from main to 3.1 August 26, 2024 11:59
@ArbaazKhan1
Copy link
Contributor Author

I added in keith's suggestions on how not fall back to tservers and the tests are now working as expected when stoping and restarting scan servers

keith-turner
keith-turner reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@keith-turner keith-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions to remove starting and stopping the scan servers during the test. Restarting the scan server during the test does not test the scan server functionality of eventually picking up new data.

test/src/main/java/org/apache/accumulo/test/ComprehensiveIT.java Outdated Show resolved Hide resolved
test/src/main/java/org/apache/accumulo/test/ComprehensiveIT.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlmarion dlmarion dlmarion left review comments

@keith-turner keith-turner keith-turner left review comments

@ctubbsii ctubbsii ctubbsii left review comments

@ddanielr ddanielr ddanielr left review comments

@kevinrr888 kevinrr888 kevinrr888 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Run eventual scans in ComprehensiveIT
6 participants
@ArbaazKhan1 @dlmarion @keith-turner @ctubbsii @ddanielr @kevinrr888