fix issue with converting text to string in MetadataConstraints in 3.x #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
approved these changes
Sep 17, 2024
| @@ -369,8 +369,7 @@ private void validateServerFamily(ArrayList<Short> violations, ColumnUpdate colu | |||
| private void validateSuspendLocationFamily(ArrayList<Short> violations, | |||
| ColumnUpdate columnUpdate) { | |||
| String qualStr = new String(columnUpdate.getColumnQualifier(), UTF_8); | |||
| String suspendColQualStr = | |||
| new String(SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().getBytes(), UTF_8); | |||
| String suspendColQualStr = SuspendLocationColumn.SUSPEND_COLUMN.getColumnQualifier().toString(); | |||
There was a problem hiding this comment.
We could make a constant for this String. For this case do not need to keep recomputing the string. Could add that constant to the SuspendLocationColumn.
There was a problem hiding this comment.
Added. Also checked the other columns in MetadataSchema; SuspendLocationColumn was the only one that wasn't consistent
made the Text name and qualifier string accessible through SuspendLocationColumn; accessed in MetadataConstraints
keith-turner
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.