Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move import to make PythonOperator working on Windows #40424

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Jun 25, 2024

As I was testing the PoC for AIP-69 (#40224) for Windows compatability I saw some error beings raised because of problematic import of fnctl in Windows.
This is used (and was introduced by me) to lock exclusive access for virtualenv install. But other code is not affected. Therefore moved the import to the location where needed and... whoops. PoC with Windows was (almost) working.

This PR therefore does not enable Windows support but fixes one of the problems.

related: #10388

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Jun 25, 2024
@potiuk potiuk force-pushed the bugfix/10388-move-import-for-windows-compatability branch from 0a7c454 to b4143a9 Compare June 26, 2024 17:24
@potiuk
Copy link
Member

potiuk commented Jun 26, 2024

Rebasing... The twine issue was caused by pypa/twine#1125 that made twine maintainer to yank 5.1.0 and release 5.1.1 2 hours ago.

@jscheffl jscheffl merged commit 923992d into apache:main Jun 26, 2024
49 checks passed
@jscheffl
Copy link
Contributor Author

@potiuk Thanks for the rebase-as-a-service, made it :-D

@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jul 1, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jul 1, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@ephraimbuddy ephraimbuddy added type:bug-fix Changelog: Bug Fixes and removed type:new-feature Changelog: New Features labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants