style(secret): _M.get and test case

apache · Aug 27, 2024 · b9d317c · b9d317c
1 parent cb26bb8
commit b9d317c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/apisix/secret/aws.lua b/apisix/secret/aws.lua
@@ -100,7 +100,7 @@ local function make_request_to_aws(conf, key)
 end
 
 -- key is the aws secretId
-local function get(conf, key)
+function _M.get(conf, key)
     core.log.info("fetching data from aws for key: ", key)
 
     local idx = find(key, '/')
@@ -131,9 +131,5 @@ local function get(conf, key)
     return data[sub_key]
 end
 
-_M.get = get
-
 
 return _M
-
-
diff --git a/t/secret/aws.t b/t/secret/aws.t
@@ -306,8 +306,11 @@ GET /t
 
             local secret = require("apisix.secret")
             local value = secret.fetch_by_uri("$secret://aws/mysecret/jack/key")
-            ngx.say(value)
+            if value then
+                ngx.say("secret value: ", value)
+            end
+            ngx.say("all done")
         }
     }
 --- response_body
-nil
+all done