-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support log with traceid when enable the zipkin plugin #10210
Conversation
Thank you for your contribution, but not everyone will be using the zipkin plugin. Perhaps you can modify it this way in your own project. |
Yes, indeed, not everyone will enable Zipkin, so the current changes should not affect users who don't use Zipkin. We've simply made user-friendly adjustments for those using Zipkin . after all, when Zipkin is in use, users expect traceId to be automatically recorded in the logs. This makes troubleshooting more convenient for everyone. I believe this capability would also be well-received by other users. What do you think? |
There are some other similar plugins like |
Sounds reasonable, then I'll close it. |
Hi @wizhuo , I understand the purpose of your PR and I also use zipkin plugin. Perhaps you can refer to this opentelemetry plugin PR for an implementation of the zipkin plugin. Would you like to help the community to explore this? Thank you for your contribution. |
Yes,I would like to do |
Description
As a user, I would like to automatically include the traceId when logging, especially when I have enabled the Zipkin plugin. This will make it easier for me to quickly identify the logs associated with a particular traceId when troubleshooting issues. Currently, manually concatenating the traceId with each log entry is cumbersome and not user-friendly. I hope that this issue can be addressed at the architectural level.
feat #10209
Checklist