Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control): add plugins/reload to control api #10905

Merged
merged 10 commits into from
Feb 19, 2024
Merged

feat(control): add plugins/reload to control api #10905

merged 10 commits into from
Feb 19, 2024

Conversation

sheharyaar
Copy link
Contributor

@sheharyaar sheharyaar commented Feb 2, 2024

Description

plugin/reload is under admin API. The admin API can only be called at the control plane (if we set the role to control plane). But we need to call the plugin/reload API at the data plane, so if we set the role of the apisix to data plane we can't call this API.

This PR moves the plugins/reload to Control API so that we can call the endpoint from the data plane. For compatibility reasons, we also need to retain this API in admin API.

Refer: https://apisix.apache.org/docs/apisix/admin-api/#plugin

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
apisix/control/v1.lua Outdated Show resolved Hide resolved
@monkeyDluffy6017
Copy link
Contributor

You mean move, do we need to remove the old API?

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Feb 4, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
@sheharyaar
Copy link
Contributor Author

@monkeyDluffy6017 @starsz please review

@monkeyDluffy6017
Copy link
Contributor

Do we need to remove the old API?

@monkeyDluffy6017
Copy link
Contributor

Can you describe in detail why do you submit this pr?

Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
apisix/control/router.lua Outdated Show resolved Hide resolved
docs/en/latest/control-api.md Outdated Show resolved Hide resolved
docs/en/latest/control-api.md Show resolved Hide resolved
apisix/control/v1.lua Outdated Show resolved Hide resolved
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
starsz
starsz previously approved these changes Feb 7, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
starsz
starsz previously approved these changes Feb 7, 2024
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
apisix/control/router.lua Show resolved Hide resolved
apisix/control/v1.lua Outdated Show resolved Hide resolved
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
@monkeyDluffy6017 monkeyDluffy6017 merged commit 21d9cee into apache:master Feb 19, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user responded wait for update wait for the author's response in this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants