Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discovery): support endpointslices in kubernetes discovery #10916

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

dongjiang1989
Copy link
Contributor

Description

This PR add support endpointslices in kubernetes discovery

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@shreemaan-abhishek
Copy link
Contributor

@dongjiang1989 please explain why this is needed, thanks.

@dongjiang1989
Copy link
Contributor Author

@dongjiang1989 please explain why this is needed, thanks.

@shreemaan-abhishek thanks for your review.

EndpointSlices provide a simple way to track network endpoints within a Kubernetes cluster. They offer a more scalable and extensible alternative to Endpoints.

ref: https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

@monkeyDluffy6017
Copy link
Contributor

Could you add test cases to cover this?

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989
Copy link
Contributor Author

@monkeyDluffy6017 @shreemaan-abhishek Please re-check. Thanks

@monkeyDluffy6017
Copy link
Contributor

@zhixiongdu027 Could you help to review this pr?

@AlinsRan
Copy link
Contributor

We should update the documentation for this feature.

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented Feb 19, 2024

We should update the documentation for this feature.

Thanks. Added it

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989
Copy link
Contributor Author

/test

@dongjiang1989
Copy link
Contributor Author

@AlinsRan @shreemaan-abhishek @monkeyDluffy6017 please re-check,thanks

@monkeyDluffy6017 monkeyDluffy6017 merged commit 869d095 into apache:master Feb 23, 2024
47 checks passed
@dongjiang1989 dongjiang1989 deleted the support-endpointslices branch February 23, 2024 11:20
@liugang594
Copy link
Contributor

@dongjiang1989
咨询一下,咱们这个endpointslice的支持,最终得到服务节点列表是全量的么?看代码中像是只得到了最后变更的slice的pod ip列表。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants