fix(prometheus): disable features when prometheus plugin is turned off #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreemaan-abhishek
force-pushed
the
fix/prometheus-disable-perf-problem
branch
from
86d0e0e
to
eab64d3
Compare
… enabled by default/design lol
starsz
reviewed
Apr 8, 2024
| @@ -344,6 +346,15 @@ function _M.load(config) | |||
| if not ok then | |||
| core.log.error("failed to load plugins: ", err) | |||
| end | |||
|
|
|||
| local enabled = core.table.array_find(http_plugin_names, "prometheus") ~= nil | |||
| local active = exporter.get_prometheus() ~= nil | |||
There was a problem hiding this comment.
I think we don't need to get the active status.
Since the exporter.destroy is harmless.
There was a problem hiding this comment.
you are right
There was a problem hiding this comment.
no I think the second if check needs the active status. Consider this case:
- apisix is running with prometheus active and enabled
- hit plugin reload
In this case enabled == true and active == true. But we need not call http_init() in prometheus because it is already running during this operation.
moonming
changed the title
starsz
approved these changes
Apr 10, 2024
moonming
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows disabling the export server when prometheus is removed from plugins list in config.yaml and then the plugin reload api is called.
Fixes #11046
Checklist